Skip to content

gh-127271: Remove the PyCell_Get usage for framelocalsproxy #130383

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
gaogaotiantian merged 8 commits into from
Feb 27, 2025
Merged

gh-127271: Remove the PyCell_Get usage for framelocalsproxy #130383

Changes from 1 commit
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
2269af5
Remove the PyCell_Get usage for framelocalsproxy
gaogaotiantian Feb 20, 2025
25491da
Fix warning
gaogaotiantian Feb 21, 2025
2a98b81
Fix style
gaogaotiantian Feb 21, 2025
2828ee2
Do check & read in a single operation
gaogaotiantian Feb 25, 2025
c22ba6b
C style
gaogaotiantian Feb 25, 2025
0373601
Fix lint
gaogaotiantian Feb 25, 2025
e396e1b
Remove unused var
gaogaotiantian Feb 25, 2025
72776f0
Use PyDict_GetItemRef
gaogaotiantian Feb 27, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
C style
  • Loading branch information
@gaogaotiantian
gaogaotiantian committed Feb 25, 2025
commit c22ba6b3b89d6fd92a29976c6f662454d0edb79c
6 changes: 4 additions & 2 deletions Objects/frameobject.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -118,7 +118,8 @@ framelocalsproxy_getkeyindex(PyFrameObject *frame, PyObject *key, bool read, PyO
if (value != NULL) {
if (value_ptr != NULL) {
*value_ptr = value;
} else {
}
else {
Py_DECREF(value);
}
return i;
Expand Down Expand Up @@ -155,7 +156,8 @@ framelocalsproxy_getkeyindex(PyFrameObject *frame, PyObject *key, bool read, PyO
if (value != NULL) {
if (value_ptr != NULL) {
*value_ptr = value;
} else {
}
else {
Py_DECREF(value);
}
return i;
Expand Down