Skip to content

gh-130120: Prevent str(zipfile.Path) from raising exception on io.BytesIO-input - #130381

Closed
yngvem wants to merge 4 commits into
python:mainfrom
yngvem:fix-zipfile-path
Closed

gh-130120: Prevent str(zipfile.Path) from raising exception on io.BytesIO-input#130381
yngvem wants to merge 4 commits into
python:mainfrom
yngvem:fix-zipfile-path

Conversation

@yngvem

@yngvem yngvem commented Feb 20, 2025 •
edited by bedevere-app Bot
Loading

Copy link
Copy Markdown
Contributor

Here are some small updates to zipfile.Path to prevent them from raising exceptions when Path-objects that are based on in-memory zipfiles are printed.

I set the printed filename to :memory: to mirror the behaviour of in-memory sqlite3 databases. However, it may also make sense to set the name to \0 (or include \0 in the name) to make it abundantly clear that this is no file.

@yngvem
yngvem requested a review from jaraco as a code owner February 20, 2025 21:20
@bedevere-app bedevere-app Bot mentioned this pull request Feb 20, 2025
Closed
jaraco
jaraco requested changes Feb 27, 2025
View reviewed changes

@jaraco jaraco left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As you've noted, there are some design decisions to make. I'm going to take those back to the issue to discuss.

Comment thread Lib/test/test_zipfile/_path/test_path.py
Comment thread Lib/test/test_zipfile/_path/test_path.py
Comment thread Misc/NEWS.d/next/Library/2025-02-20-21-30-41.gh-issue-130120.-O2xJr.rst
@bedevere-app

bedevere-app Bot commented Feb 27, 2025

Copy link
Copy Markdown

A Python core developer has requested some changes be made to your pull request before we can consider merging it. If you could please address their requests along with any other requests in other reviews from core developers that would be appreciated.

Once you have made the requested changes, please leave a comment on this pull request containing the phrase I have made the requested changes; please review again. I will then notify any core developers who have left a review that you're ready for them to take another look at this pull request.

@jaraco

jaraco commented Feb 27, 2025

Copy link
Copy Markdown
Member

Given the history I've recently been reminded of in #100609, I'm going to close this PR. Hang onto the branch, though, in case we decide to go with something like you've drafted. Thanks for understanding.

@jaraco jaraco closed this Feb 27, 2025
@yngvem yngvem mentioned this pull request Mar 28, 2025
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jaraco jaraco jaraco requested changes

Assignees

No one assigned

Labels

awaiting changes

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@yngvem @jaraco