Skip to content

gh-130163: Fix usage of borrow references from _PySys_GetAttr #130282

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
sergey-miryanov wants to merge 10 commits into from
Closed

gh-130163: Fix usage of borrow references from _PySys_GetAttr #130282

Changes from 1 commit
Commits
Show all changes
10 commits
Select commit Hold shift + click to select a range
f5b64f6
Add test for changing stdout from thread
sergey-miryanov Feb 18, 2025
97e0b2e
Add tests for faulthandler
sergey-miryanov Feb 20, 2025
1987fb2
Add tests for warnings and simplify for print
sergey-miryanov Feb 20, 2025
f13cdbb
Add tests for input
sergey-miryanov Feb 21, 2025
1d0b0e0
Add test for unraisablehook
sergey-miryanov Feb 21, 2025
9cf4173
Add tests for pylifecycle/flush_std_files
sergey-miryanov Feb 22, 2025
e65b17c
Fix tests for input
sergey-miryanov Feb 22, 2025
93d9fb7
Add test for _PyErr_PrintEx
sergey-miryanov Feb 22, 2025
4139409
Simplify tests for print and add _check to unify tests
sergey-miryanov Feb 23, 2025
9220dd2
Add comments to tests
sergey-miryanov Feb 24, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Add tests for input
  • Loading branch information
@sergey-miryanov
sergey-miryanov committed Feb 21, 2025
commit f13cdbb453d7ab7e5dd091a71fcf527c69ddcfc3
87 changes: 87 additions & 0 deletions Lib/test/test_sys_getattr.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -70,6 +70,63 @@ def main():
exit(0)
''')

common_input_code = textwrap.dedent('''
import sys

class FakeIO:
def write(self, str):
pass
def flush(self):
pass
def fileno(self):
return 0

class CrashStdin:
def __init__(self):
self.stdin = sys.stdin
setattr(sys, "stdin", FakeIO())

def __repr__(self):
stdin = sys.stdin
setattr(sys, "stdin", self.stdin)
del stdin
return "CrashStdin"

class CrashStdout:
def __init__(self):
self.stdout = sys.stdout
setattr(sys, "stdout", FakeIO())

def __repr__(self):
stdout = sys.stdout
setattr(sys, "stdout", self.stdout)
del stdout
return "CrashStdout"

class CrashStderr:
def __init__(self):
self.stderr = sys.stderr
setattr(sys, "stderr", FakeIO())

def __repr__(self):
stderr = sys.stderr
setattr(sys, "stderr", self.stderr)
del stderr
return "CrashStderr"

def audit(event, args):
if event == 'builtins.input':
repr(args)

def main():
{0}
input({1})

if __name__ == "__main__":
main()

''')


def test_print_deleted_stdout(self):
# print should use strong reference to the stdout.
Expand Down Expand Up @@ -157,5 +214,35 @@ def test_warnings_warn_explicit(self):
self.assertNotIn(b"Segmentation fault", err)
self.assertNotIn(b"access violation", err)

def test_input_stdin(self):
test_code = self.common_input_code.format(
"",
"CrashStdin()"
)
rc, _, err = assert_python_ok('-c', test_code)
self.assertEqual(rc, 0)
self.assertNotIn(b"Segmentation fault", err)
self.assertNotIn(b"access violation", err)

def test_input_stdout(self):
test_code = self.common_input_code.format(
"",
"CrashStdout()"
)
rc, _, err = assert_python_ok('-c', test_code)
self.assertEqual(rc, 0)
self.assertNotIn(b"Segmentation fault", err)
self.assertNotIn(b"access violation", err)

def test_input_stderr(self):
test_code = self.common_input_code.format(
"sys.addaudithook(audit)",
"CrashStderr()"
)
rc, _, err = assert_python_ok('-c', test_code)
self.assertEqual(rc, 0)
self.assertNotIn(b"Segmentation fault", err)
self.assertNotIn(b"access violation", err)

if __name__ == "__main__":
unittest.main()