Skip to content

gh-124622: Add PyThreadState_Ensure() function #130012

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
vstinner wants to merge 11 commits into from
Closed

gh-124622: Add PyThreadState_Ensure() function #130012

Changes from 1 commit
Commits
Show all changes
11 commits
Select commit Hold shift + click to select a range
e46b723
gh-124622: Add PyThreadState_Ensure() function
vstinner Feb 5, 2025
af5b1b1
Use current_fast_get()
vstinner Feb 16, 2025
eaa125f
should => must
vstinner Feb 18, 2025
1e3762a
Add 'errmsg' parameter
vstinner Feb 19, 2025
7455fd5
Document errmsg
vstinner Feb 27, 2025
1c3669a
start by setting *errmsg to NULL
vstinner Mar 10, 2025
178507e
Reject tstate from another interpreter
vstinner Mar 10, 2025
325309c
No longer share code with PyGILState
vstinner Mar 10, 2025
820d9fe
Add tests
vstinner Mar 10, 2025
7ba7aa0
Complete test
vstinner Mar 10, 2025
783d91f
Update comment
vstinner Mar 10, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
start by setting *errmsg to NULL
  • Loading branch information
@vstinner
vstinner committed Mar 10, 2025
commit 1c3669a9a6c7b8d730731c86901fdbe9c1557394
7 changes: 4 additions & 3 deletions Python/pystate.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2756,6 +2756,10 @@ static int
tstate_ensure(PyInterpreterState *interp, PyThreadState *tcur,
const char **errmsg)
{
if (errmsg) {
*errmsg = NULL;
}

int has_gil;
if (tcur == NULL) {
Comment thread
vstinner marked this conversation as resolved.
/* Create a new Python thread state for this thread */
Expand Down Expand Up @@ -2790,9 +2794,6 @@ tstate_ensure(PyInterpreterState *interp, PyThreadState *tcur,
*/
++tcur->gilstate_counter;

if (errmsg) {
*errmsg = NULL;
}
return has_gil ? PyGILState_LOCKED : PyGILState_UNLOCKED;
}

Expand Down