Skip to content

gh-128002: optimistically remove tasks from linked list when finished #129995

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
kumaraditya303 merged 3 commits into from
Feb 13, 2025
Merged

gh-128002: optimistically remove tasks from linked list when finished #129995

Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
6f3db4b
optimistic
kumaraditya303 Feb 7, 2025
33f1ee8
Merge branch 'main' of https://github.com/python/cpython into optimistic
kumaraditya303 Feb 11, 2025
ba20f49
add comment
kumaraditya303 Feb 11, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Next Next commit
optimistic
  • Loading branch information
@kumaraditya303
kumaraditya303 committed Feb 7, 2025
commit 6f3db4b017f293933fed822578bd9e8f12217a04
9 changes: 9 additions & 0 deletions Modules/_asynciomodule.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -413,12 +413,20 @@ future_ensure_alive(FutureObj *fut)
} \
} while(0);

static void unregister_task(asyncio_state *state, TaskObj *task);

static int
future_schedule_callbacks(asyncio_state *state, FutureObj *fut)
{
_Py_CRITICAL_SECTION_ASSERT_OBJECT_LOCKED(fut);

assert(fut->fut_state != STATE_PENDING);

if (Task_Check(state, fut)) {
TaskObj *task = (TaskObj *)fut;
unregister_task(state, task);
}

if (fut->fut_callback0 != NULL) {
/* There's a 1st callback */

Expand Down Expand Up @@ -4019,6 +4027,7 @@ add_tasks_llist(struct llist_node *head, PyListObject *tasks)
struct llist_node *node;
llist_for_each_safe(node, head) {
TaskObj *task = llist_data(node, TaskObj, task_node);
assert(task->task_state == STATE_PENDING);
// The linked list holds borrowed references to task
// as such it is possible that the task is concurrently
// deallocated while added to this list.
Expand Down