Skip to content

GH-125413: Add private metadata methods to pathlib.Path.info #129897

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
barneygale merged 16 commits into from
Feb 17, 2025
Merged

GH-125413: Add private metadata methods to pathlib.Path.info #129897

Changes from 1 commit
Commits
Show all changes
16 commits
Select commit Hold shift + click to select a range
4dd7c21
GH-125413: Add private metadata methods to `pathlib.Path.info`
barneygale Feb 9, 2025
30faab7
Fix atime/mtime copying
barneygale Feb 9, 2025
22e065d
Simplify patch
barneygale Feb 9, 2025
cd4a1b5
Improve naming
barneygale Feb 9, 2025
07f89a4
Return `None` if results aren't available.
barneygale Feb 9, 2025
2026886
Merge `_create_metadata()` and `_create_symlink_metadata()`
barneygale Feb 9, 2025
ba4d393
Simplify patch a bit
barneygale Feb 9, 2025
6cde4fb
Further reduce diff
barneygale Feb 9, 2025
0871a39
Stop suppressing stat() errors from new methods
barneygale Feb 9, 2025
89e49bf
Stop using `samefile()`, add `_file_id()` and `_device_id()`
barneygale Feb 11, 2025
86b671f
Attempt to fix access time test
barneygale Feb 12, 2025
f6b2249
Delete `_device_id()`
barneygale Feb 13, 2025
47616de
Merge branch 'main' into gh-125413-merge-copyreader
barneygale Feb 13, 2025
bc9032b
Merge branch 'main' into gh-125413-merge-copyreader
barneygale Feb 16, 2025
6c03d51
Merge branch 'main' into gh-125413-merge-copyreader
encukou Feb 17, 2025
13db1fe
`_create_metadata` -> `_copy_metadata`
barneygale Feb 17, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Merge _create_metadata() and _create_symlink_metadata()
  • Loading branch information
@barneygale
barneygale committed Feb 9, 2025
commit 202688681c46dcc60ac824a65b1bf0fddef4f1d8
98 changes: 30 additions & 68 deletions Lib/pathlib/_os.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -257,16 +257,12 @@ def _create_symlink(self, source, preserve_metadata):
"""Copy the given symbolic link to our path."""
self._path.symlink_to(source.readlink())
if preserve_metadata:
self._create_symlink_metadata(source)
self._create_metadata(source, follow_symlinks=False)

def _create_metadata(self, source):
def _create_metadata(self, source, follow_symlinks=True):
"""Copy metadata from the given path to our path."""
pass

def _create_symlink_metadata(self, source):
"""Copy metadata from the given symlink to our symlink."""
pass

def _ensure_different_file(self, source):
"""
Raise OSError(EINVAL) if both paths refer to the same file.
Expand Down Expand Up @@ -317,91 +313,57 @@ def _create_symlink(self, source, preserve_metadata):
"""Copy the given symlink to the given target."""
self._path.symlink_to(source.readlink(), source.is_dir())
if preserve_metadata:
self._create_symlink_metadata(source)
self._create_metadata(source, follow_symlinks=False)

def _create_metadata(self, source):
def _create_metadata(self, source, follow_symlinks=True):
"""Copy metadata from the given path to our path."""
>
info = source.info
copy_times_ns = hasattr(info, '_access_time_ns') and hasattr(info, '_mod_time_ns')
if copy_times_ns:
access_time_ns = info._access_time_ns()
mod_time_ns = info._mod_time_ns()
if access_time_ns is not None and mod_time_ns is not None:
os.utime(target, ns=(access_time_ns, mod_time_ns))

copy_xattrs = hasattr(info, '_xattrs') and hasattr(os, 'setxattr')
if copy_xattrs:
xattrs = info._xattrs()
if xattrs is not None:
for attr, value in xattrs:
try:
os.setxattr(target, attr, value)
except OSError as e:
if e.errno not in (EPERM, ENOTSUP, ENODATA, EINVAL, EACCES):
raise

copy_posix_permissions = hasattr(info, '_posix_permissions')
if copy_posix_permissions:
posix_permissions = info._posix_permissions()
if posix_permissions is not None:
os.chmod(target, posix_permissions)

copy_bsd_flags = hasattr(info, '_bsd_flags') and hasattr(os, 'chflags')
if copy_bsd_flags:
bsd_flags = info._bsd_flags()
if bsd_flags is not None:
try:
os.chflags(target, bsd_flags)
except OSError as why:
if why.errno not in (EOPNOTSUPP, ENOTSUP):
raise

def _create_symlink_metadata(self, source):
"""Copy metadata from the given symlink to our symlink."""
>
info = source.info

copy_times_ns = (hasattr(info, '_access_time_ns') and
hasattr(info, '_mod_time_ns') and
os.utime in os.supports_follow_symlinks)
copy_times_ns = (
hasattr(info, '_access_time_ns') and
hasattr(info, '_mod_time_ns') and
(follow_symlinks or os.utime in os.supports_follow_symlinks))
if copy_times_ns:
access_time_ns = info._access_time_ns(follow_symlinks=False)
mod_time_ns = info._mod_time_ns(follow_symlinks=False)
if access_time_ns is not None and mod_time_ns is not None:
os.utime(target, ns=(access_time_ns, mod_time_ns), follow_symlinks=False)

copy_xattrs = (hasattr(info, '_xattrs') and
hasattr(os, 'setxattr') and
os.setxattr in os.supports_fd)
t0 = info._access_time_ns(follow_symlinks=follow_symlinks)
t1 = info._mod_time_ns(follow_symlinks=follow_symlinks)
if t0 is not None and t1 is not None:
os.utime(target, ns=(t0, t1), follow_symlinks=follow_symlinks)

copy_xattrs = (
hasattr(info, '_xattrs') and
hasattr(os, 'setxattr') and
(follow_symlinks or os.setxattr in os.supports_follow_symlinks))
if copy_xattrs:
xattrs = info._xattrs(follow_symlinks=False)
xattrs = info._xattrs(follow_symlinks=follow_symlinks)
if xattrs is not None:
for attr, value in xattrs:
try:
os.setxattr(target, attr, value, follow_symlinks=False)
os.setxattr(target, attr, value, follow_symlinks=follow_symlinks)
except OSError as e:
if e.errno not in (EPERM, ENOTSUP, ENODATA, EINVAL, EACCES):
raise

copy_posix_permissions = (hasattr(info, '_posix_permissions') and
hasattr(os, 'lchmod'))
copy_posix_permissions = (
hasattr(info, '_posix_permissions') and
(follow_symlinks or os.chmod in os.supports_follow_symlinks))
if copy_posix_permissions:
posix_permissions = info._posix_permissions(follow_symlinks=False)
posix_permissions = info._posix_permissions(follow_symlinks=follow_symlinks)
if posix_permissions is not None:
try:
os.lchmod(target, posix_permissions)
os.chmod(target, posix_permissions, follow_symlinks=follow_symlinks)
except NotImplementedError:
pass

copy_bsd_flags = (hasattr(info, '_bsd_flags') and
hasattr(os, 'chflags') and
os.chflags in os.supports_follow_symlinks)
copy_bsd_flags = (
hasattr(info, '_bsd_flags') and
hasattr(os, 'chflags') and
(follow_symlinks or os.chflags in os.supports_follow_symlinks))
if copy_bsd_flags:
bsd_flags = info._bsd_flags(follow_symlinks=False)
bsd_flags = info._bsd_flags(follow_symlinks=follow_symlinks)
if bsd_flags is not None:
try:
os.chflags(target, bsd_flags, follow_symlinks=False)
os.chflags(target, bsd_flags, follow_symlinks=follow_symlinks)
except OSError as why:
if why.errno not in (EOPNOTSUPP, ENOTSUP):
raise
Expand Down