Skip to content

gh-111178: fix UBSan failures in Modules/_threadmodule.c #129794

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
encukou merged 12 commits into from
Feb 24, 2025
Merged

gh-111178: fix UBSan failures in Modules/_threadmodule.c #129794

Changes from 1 commit
Commits
Show all changes
12 commits
Select commit Hold shift + click to select a range
9447294
fix UBSan failures for `PyThreadHandleObject`
picnixz Jan 25, 2025
1083c46
use a macro for casts to `lockobject`
picnixz Jan 25, 2025
d7a39ae
fix UBSan failures for `rlockobject`
picnixz Jan 25, 2025
557dbd0
fix UBSan failures for `localdummyobject`
picnixz Jan 25, 2025
a96a296
fix UBSan failures for `localobject`
picnixz Jan 25, 2025
339a416
add safe casts
picnixz Jan 25, 2025
17ba461
cleanup module functions
picnixz Jan 25, 2025
4b3e706
use semantically correct parameter names
picnixz Feb 6, 2025
122f2ee
Merge remote-tracking branch 'upstream/main' into fix/ubsan/thread-11…
picnixz Feb 7, 2025
7a5ed41
Do Do not use `_` + capital letter in new code as it is also UB.
picnixz Feb 8, 2025
ce0eb11
Do not add an underscore to the macro if none is needed.
picnixz Feb 8, 2025
59a33e3
Merge branch 'main' into fix/ubsan/thread-111178
encukou Feb 18, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Next Next commit
fix UBSan failures for PyThreadHandleObject
  • Loading branch information
@picnixz
picnixz committed Jan 25, 2025
commit 94472946551424b7dc77a5190e6d7f0a6b565020
17 changes: 9 additions & 8 deletions Modules/_threadmodule.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -582,6 +582,8 @@ typedef struct {
ThreadHandle *handle;
} PyThreadHandleObject;

#define _PyThreadHandleObject_CAST(op) ((PyThreadHandleObject *)(op))

static PyThreadHandleObject *
PyThreadHandleObject_new(PyTypeObject *type)
{
Expand Down Expand Up @@ -609,8 +611,7 @@ PyThreadHandleObject_tp_new(PyTypeObject *type, PyObject *args, PyObject *kwds)
}

static int
PyThreadHandleObject_traverse(PyThreadHandleObject *self, visitproc visit,
void *arg)
PyThreadHandleObject_traverse(PyObject *self, visitproc visit, void *arg)
{
Py_VISIT(Py_TYPE(self));
return 0;
Expand All @@ -619,7 +620,7 @@ PyThreadHandleObject_traverse(PyThreadHandleObject *self, visitproc visit,
static void
PyThreadHandleObject_dealloc(PyObject *op)
{
PyThreadHandleObject *self = (PyThreadHandleObject*)op;
PyThreadHandleObject *self = _PyThreadHandleObject_CAST(op);
PyObject_GC_UnTrack(self);
PyTypeObject *tp = Py_TYPE(self);
ThreadHandle_decref(self->handle);
Expand All @@ -630,7 +631,7 @@ PyThreadHandleObject_dealloc(PyObject *op)
static PyObject *
PyThreadHandleObject_repr(PyObject *op)
{
PyThreadHandleObject *self = (PyThreadHandleObject*)op;
PyThreadHandleObject *self = _PyThreadHandleObject_CAST(op);
PyThread_ident_t ident = ThreadHandle_ident(self->handle);
return PyUnicode_FromFormat("<%s object: ident=%" PY_FORMAT_THREAD_IDENT_T ">",
Py_TYPE(self)->tp_name, ident);
Expand All @@ -639,14 +640,14 @@ PyThreadHandleObject_repr(PyObject *op)
static PyObject *
PyThreadHandleObject_get_ident(PyObject *op, void *Py_UNUSED(ignored))
{
PyThreadHandleObject *self = (PyThreadHandleObject*)op;
PyThreadHandleObject *self = _PyThreadHandleObject_CAST(op);
return PyLong_FromUnsignedLongLong(ThreadHandle_ident(self->handle));
}

static PyObject *
PyThreadHandleObject_join(PyObject *op, PyObject *args)
{
PyThreadHandleObject *self = (PyThreadHandleObject*)op;
PyThreadHandleObject *self = _PyThreadHandleObject_CAST(op);

PyObject *timeout_obj = NULL;
if (!PyArg_ParseTuple(args, "|O:join", &timeout_obj)) {
Expand All @@ -670,7 +671,7 @@ PyThreadHandleObject_join(PyObject *op, PyObject *args)
static PyObject *
PyThreadHandleObject_is_done(PyObject *op, PyObject *Py_UNUSED(ignored))
{
PyThreadHandleObject *self = (PyThreadHandleObject*)op;
PyThreadHandleObject *self = _PyThreadHandleObject_CAST(op);
if (_PyEvent_IsSet(&self->handle->thread_is_exiting)) {
Py_RETURN_TRUE;
}
Expand All @@ -682,7 +683,7 @@ PyThreadHandleObject_is_done(PyObject *op, PyObject *Py_UNUSED(ignored))
static PyObject *
PyThreadHandleObject_set_done(PyObject *op, PyObject *Py_UNUSED(ignored))
{
PyThreadHandleObject *self = (PyThreadHandleObject*)op;
PyThreadHandleObject *self = _PyThreadHandleObject_CAST(op);
if (ThreadHandle_set_done(self->handle) < 0) {
return NULL;
}
Expand Down