Skip to content

gh-111178: fix UBSan failures in Modules/cjkcodecs/multibytecodec.c #129090

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
corona10 merged 9 commits into from
Jan 25, 2025
Merged

gh-111178: fix UBSan failures in Modules/cjkcodecs/multibytecodec.c #129090

Changes from 1 commit
Commits
Show all changes
9 commits
Select commit Hold shift + click to select a range
d5a8c23
Add casts macros
picnixz Jan 20, 2025
efff446
fix UBSan failures for `MultibyteCodecObject`
picnixz Jan 20, 2025
a9fe498
fix UBSan failures for `MultibyteIncrementalEncoderObject`
picnixz Jan 20, 2025
9ed213b
fix UBSan failures for `MultibyteIncrementalDecoderObject`
picnixz Jan 20, 2025
4bcb9b3
fix UBSan failures for `MultibyteStreamReaderObject`
picnixz Jan 20, 2025
0c6d52b
fix UBSan failures for `MultibyteStreamWriterObject`
picnixz Jan 20, 2025
85b6e93
suppress unused return values
picnixz Jan 20, 2025
eb6df00
fixup
picnixz Jan 20, 2025
97cd79b
Move cast macros to `.c`
picnixz Jan 20, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
fix UBSan failures for MultibyteIncrementalEncoderObject
  • Loading branch information
@picnixz
picnixz committed Jan 20, 2025
commit a9fe4985c9b82b11aee92c260856d8d02b952687
7 changes: 4 additions & 3 deletions Modules/cjkcodecs/multibytecodec.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1108,17 +1108,18 @@ mbiencoder_init(PyObject *self, PyObject *args, PyObject *kwds)
}

static int
mbiencoder_traverse(MultibyteIncrementalEncoderObject *self,
visitproc visit, void *arg)
mbiencoder_traverse(PyObject *op, visitproc visit, void *arg)
{
MultibyteIncrementalEncoderObject *self = _MultibyteIncrementalEncoderObject_CAST(op);
if (ERROR_ISCUSTOM(self->errors))
Py_VISIT(self->errors);
return 0;
}

static void
mbiencoder_dealloc(MultibyteIncrementalEncoderObject *self)
mbiencoder_dealloc(PyObject *op)
{
MultibyteIncrementalEncoderObject *self = _MultibyteIncrementalEncoderObject_CAST(op);
PyTypeObject *tp = Py_TYPE(self);
PyObject_GC_UnTrack(self);
ERROR_DECREF(self->errors);
Expand Down