Skip to content

GH-128914: Remove conditional stack effects from bytecodes.c and the code generators #128918

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
markshannon merged 21 commits into from
Jan 20, 2025
Merged

GH-128914: Remove conditional stack effects from bytecodes.c and the code generators #128918

Changes from 1 commit
Commits
Show all changes
21 commits
Select commit Hold shift + click to select a range
d85c001
No conditional stack effects for LOAD_GLOBAL or LOAD_ATTR
markshannon Jan 15, 2025
053327a
No conditional stack effects for LOAD_SUPER_ATTR or CALL_FUNCTION_EX
markshannon Jan 15, 2025
029f844
Remove support for conditional stack effects from code generators
markshannon Jan 15, 2025
0f49a42
Fix up tests
markshannon Jan 15, 2025
0515341
Remove 'split' annotation
markshannon Jan 15, 2025
402787c
Rename result of PUSH_NULL
markshannon Jan 16, 2025
6ac95d4
Use full oparg for name index in LOAD_GLOBAL and LOAD_ATTR
markshannon Jan 16, 2025
3e475e8
Use correct magic number
markshannon Jan 16, 2025
a766382
Fix magic number comment
markshannon Jan 16, 2025
4104065
Remove unused function
markshannon Jan 16, 2025
6c1a7eb
Merge branch 'main' into no-conditional-stack-effects
markshannon Jan 16, 2025
17249ba
Update Lib/test/test_monitoring.py
markshannon Jan 16, 2025
9ce0600
Merge branch 'main' into no-conditional-stack-effects
markshannon Jan 17, 2025
7806d43
Merge remote-tracking branch 'faster/no-conditional-stack-effects' in…
markshannon Jan 17, 2025
bbcc0df
Document new LOAD_METHOD instruction. Update docs for LOAD_ATTR
markshannon Jan 17, 2025
0a2f9d1
Add news
markshannon Jan 17, 2025
be67c3e
Remove old docs for LOAD_METHOD
markshannon Jan 17, 2025
5e547a5
Fix example
markshannon Jan 17, 2025
a805197
Fix another example
markshannon Jan 17, 2025
2c2ae8d
Merge branch 'main' into no-conditional-stack-effects
markshannon Jan 20, 2025
d5e47ea
Merge branch 'main' into no-conditional-stack-effects
markshannon Jan 20, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Merge branch 'main' into no-conditional-stack-effects
  • Loading branch information
@markshannon
markshannon committed Jan 20, 2025
commit 2c2ae8dee9f9dd73c7644df150db06b535e90420
2 changes: 1 addition & 1 deletion Tools/cases_generator/stack.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -259,7 +259,7 @@ def pop(self, var: StackItem) -> tuple[str, Local]:
return "", Local.unused(var)
self.defined.add(var.name)
cast = f"({var.type})" if (not indirect and var.type) else ""
bits = ".bits" if cast and extract_bits else ""
bits = ".bits" if cast and self.extract_bits else ""
assign = f"{var.name} = {cast}{indirect}stack_pointer[{self.base_offset.to_c()}]{bits};\n"
return assign, Local.from_memory(var)

Expand Down
You are viewing a condensed version of this merge commit. You can view the full changes here.