Skip to content

gh-115999: Add free-threaded specialization for FOR_ITER #128798

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Yhg1s merged 15 commits into from
Mar 12, 2025
Merged

gh-115999: Add free-threaded specialization for FOR_ITER #128798

Changes from 1 commit
Commits
Show all changes
15 commits
Select commit Hold shift + click to select a range
54c551e
Add free-threaded specialization for lists and tuples.
Yhg1s Jan 13, 2025
1433cd3
Add specialization for range iterators and generators, both about as
Yhg1s Jan 13, 2025
a662ecf
Add missing ifdef guard.
Yhg1s Jan 13, 2025
2fef94b
Fix copy-paste mistake.
Yhg1s Jan 13, 2025
0870ce7
Regen cases.
Yhg1s Jan 13, 2025
cf5fcd0
Rework FOR_ITER specialization in the free-threaded build to only app…
Yhg1s Jan 21, 2025
bb495b0
Fix whitespace for linter.
Yhg1s Jan 21, 2025
940b7c9
Incorporate changes from #128445 into the free-threaded branch of
Yhg1s Jan 21, 2025
a800d75
Drop redundant assert.
Yhg1s Jan 21, 2025
1781cad
Don't mark _PyList_GetItemRefNoLock as non-escaping.
Yhg1s Jan 24, 2025
358199a
Address reviewer comments, and drop test_iteration_deopt.
Yhg1s Jan 26, 2025
5c16a5e
Merge branch 'main' into for-iter-spec
Yhg1s Feb 18, 2025
07d3033
Regenerate cases after merge.
Yhg1s Feb 18, 2025
4326376
Merge branch 'main' into for-iter-spec
Yhg1s Mar 5, 2025
375399d
Make the free-threaded FOR_ITER work in the tier 2 interpreter/jit.
Yhg1s Mar 5, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Add missing ifdef guard.
  • Loading branch information
@Yhg1s
Yhg1s committed Jan 13, 2025
commit a662ecf95f0beeae5a75e24585573c8c7b94aff8
2 changes: 2 additions & 0 deletions Python/specialize.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2652,6 +2652,7 @@ _Py_Specialize_ForIter(_PyStackRef iter, _Py_CODEUNIT *instr, int oparg)
PyObject *iter_o = PyStackRef_AsPyObjectBorrow(iter);
PyTypeObject *tp = Py_TYPE(iter_o);
if (tp == &PyListIter_Type) {
#ifdef Py_GIL_DISABLED
_PyListIterObject *it = (_PyListIterObject *)iter_o;
if (!_Py_IsOwnedByCurrentThread((PyObject *)it->it_seq) &&
!_PyObject_GC_IS_SHARED(it->it_seq)) {
Expand All @@ -2661,6 +2662,7 @@ _Py_Specialize_ForIter(_PyStackRef iter, _Py_CODEUNIT *instr, int oparg)
unspecialize(instr);
return;
}
#endif
specialize(instr, FOR_ITER_LIST);
return;
}
Expand Down