Skip to content

gh-125985: Fix cmodule_function() scaling benchmark #128460

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
colesbury merged 2 commits into from
Jan 3, 2025
Merged

gh-125985: Fix cmodule_function() scaling benchmark #128460

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
f65937c
gh-125985: Fix `cmodule_function()` scaling benchmark
colesbury Jan 3, 2025
272daf3
Update Tools/ftscalingbench/ftscalingbench.py
colesbury Jan 3, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Next Next commit
gh-125985: Fix cmodule_function() scaling benchmark 
Add a separate benchmark that measures the effect of
`_PyObject_LookupSpecial()` on scaling.

In the process of cleaning up the scaling benchmarks for inclusion, I
unintentionally changed the "cmodule_function" benchmark to pass an
`int` to `math.floor()` instead of a `float`, which causes it to use the
`_PyObject_LookupSpecial()` code path. `_PyObject_LookupSpecial()` has
its own scaling issues that we want to measure separately from calling a
function on a C module.
  • Loading branch information
@colesbury
colesbury committed Jan 3, 2025
commit f65937cbfb6e6990662e6bfed54ff59a524d9358
12 changes: 10 additions & 2 deletions Tools/ftscalingbench/ftscalingbench.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -54,8 +54,16 @@ def object_cfunction():

@register_benchmark
def cmodule_function():
N = 1000 * WORK_SCALE
for i in range(N):
math.cos(i / N)

@register_benchmark
def object_lookup_special():
# round() uses `_PyObject_LookupSpecial()` internally.
N = 1000 * WORK_SCALE
for i in range(1000 * WORK_SCALE):
Comment thread
colesbury marked this conversation as resolved.
Outdated
math.floor(i * i)
round(i / N)

@register_benchmark
def mult_constant():
Expand Down Expand Up @@ -206,7 +214,7 @@ def benchmark(func):
color = "\x1b[33m" # yellow
reset_color = "\x1b[0m"

print(f"{color}{func.__name__:<18} {round(factor, 1):>4}x {direction}{reset_color}")
print(f"{color}{func.__name__:<25} {round(factor, 1):>4}x {direction}{reset_color}")

def determine_num_threads_and_affinity():
if sys.platform != "linux":
Expand Down