Skip to content

gh-128400: Stop-the-world when manually calling faulthandler #128422

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
colesbury merged 3 commits into from
Jan 2, 2025
Merged

gh-128400: Stop-the-world when manually calling faulthandler #128422

Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
a8cf48a
gh-128400: Stop the world when calling manually
ZeroIntensity Jan 2, 2025
b9e4d48
Add blurb
ZeroIntensity Jan 2, 2025
b19d49f
Add a test.
ZeroIntensity Jan 2, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Add a test.
  • Loading branch information
@ZeroIntensity
ZeroIntensity committed Jan 2, 2025
commit b19d49f6a7bc6467ff1b10cd561f911288dd643c
30 changes: 29 additions & 1 deletion Lib/test/test_faulthandler.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,7 @@
import subprocess
import sys
from test import support
from test.support import os_helper, script_helper, is_android, MS_WINDOWS
from test.support import os_helper, script_helper, is_android, MS_WINDOWS, threading_helper
import tempfile
import unittest
from textwrap import dedent
Expand Down Expand Up @@ -896,6 +896,34 @@ def test_cancel_later_without_dump_traceback_later(self):
self.assertEqual(output, [])
self.assertEqual(exitcode, 0)

@threading_helper.requires_working_threading()
@unittest.skipUnless(support.Py_GIL_DISABLED, "only meaningful if the GIL is disabled")
def test_free_threaded_dump_traceback(self):
# gh-128400: Other threads need to be paused to invoke faulthandler
code = dedent("""
import faulthandler
from threading import Thread, Event

class Waiter(Thread):
def __init__(self):
Thread.__init__(self)
self.running = Event()
self.stop = Event()

def run(self):
self.running.set()
self.stop.wait()

for _ in range(100):
waiter = Waiter()
waiter.start()
waiter.running.wait()
faulthandler.dump_traceback(all_threads=True)
waiter.stop.set()
waiter.join()
""")
_, exitcode = self.get_output(code)
self.assertEqual(exitcode, 0)

if __name__ == "__main__":
unittest.main()