Skip to content

gh-128321: Set LIBS instead of LDFLAGS during sqlite3 library build checks #128322

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
erlend-aasland merged 3 commits into from
Dec 30, 2024
Merged

gh-128321: Set LIBS instead of LDFLAGS during sqlite3 library build checks #128322

Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
478374c
Set `LIBS` during sqlite3 library build checks
zanieb Dec 29, 2024
2fea651
Use LIBS iso. LDFLAGS for sqlite3 func checks
erlend-aasland Dec 29, 2024
0f2f2c9
Update news blurb
zanieb Dec 30, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Update news blurb
  • Loading branch information
@zanieb
zanieb committed Dec 30, 2024
commit 0f2f2c9cada6ca260744374ffe934354646c45b6
5 changes: 3 additions & 2 deletions Misc/NEWS.d/next/Build/2024-12-28-21-05-19.gh-issue-128321.0UvbXw.rst
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,2 +1,3 @@
Set ``LIBS`` when checking if :mod:`sqlite3` library functions are
available.
Set ``LIBS`` instead of ``LDFLAGS`` when checking if :mod:`sqlite3` library
functions are available. This fixes the ordering of linked libraries during
checks, which was incorrect when using a statically linked ``libsqlite3``.