Skip to content

gh-111178: fix UBSan failures in Modules/{blake2,md5,sha1,sha2,sha3}module.c #128248

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
encukou merged 14 commits into from
Jan 27, 2025
Merged

gh-111178: fix UBSan failures in Modules/{blake2,md5,sha1,sha2,sha3}module.c #128248

Changes from 1 commit
Commits
Show all changes
14 commits
Select commit Hold shift + click to select a range
4774f0c
fix UBSan failures in `sha3module.c`
picnixz Dec 23, 2024
d4179e1
fix UBSan failures in `sha2module.c`
picnixz Dec 23, 2024
83b696b
fix UBSan failures in `sha1module.c`
picnixz Dec 23, 2024
a0e2b2a
fix UBSan failures in `md5module.c`
picnixz Dec 23, 2024
e43effb
suppress unused return values
picnixz Dec 23, 2024
ecf78f9
remove redundant casts in constructors
picnixz Dec 23, 2024
d9452e8
suppress unused parameters in `{md5,sha*}module.c`
picnixz Dec 23, 2024
61a0de8
fix UBSan failures for `blake2module.c`
picnixz Dec 25, 2024
568bff8
suppress unused parameters in `blake2module.c`
picnixz Dec 25, 2024
494565a
Merge remote-tracking branch 'upstream/main' into fix/ubsan/sha-111178
picnixz Jan 14, 2025
3d85690
reduce diff
picnixz Jan 14, 2025
34e8b55
reduce diff
picnixz Jan 14, 2025
20bf303
reduce diff
picnixz Jan 14, 2025
e06f834
Merge branch 'main' into fix/ubsan/sha-111178
picnixz Jan 18, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Merge remote-tracking branch 'upstream/main' into fix/ubsan/sha-111178
  • Loading branch information
@picnixz
picnixz committed Jan 14, 2025
commit 494565a8ddbf15e67e814a50251dc46582d779d1
10 changes: 7 additions & 3 deletions Modules/blake2module.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -899,10 +899,14 @@ static PyGetSetDef py_blake2b_getsetters[] = {
};


static void
py_blake2b_dealloc(PyObject *op)
static int
py_blake2_clear(PyObject *op)
{
Blake2Object *self = _Blake2Object_CAST(op);
Blake2Object *self = (Blake2Object *)op;
// The initialization function uses PyObject_GC_New() but explicitly
// initializes the HACL* internal state to NULL before allocating
// it. If an error occurs in the constructor, we should only free
// states that were allocated (i.e. that are not NULL).
switch (self->impl) {
#if HACL_CAN_COMPILE_SIMD256
case Blake2b_256:
Expand Down
You are viewing a condensed version of this merge commit. You can view the full changes here.