Skip to content

gh-111178: fix UBSan failures in Python/bltinmodule.c #128235

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
encukou merged 4 commits into from
Jan 10, 2025
Merged

gh-111178: fix UBSan failures in Python/bltinmodule.c #128235

Changes from 1 commit
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
5230000
fix UBSan failures for `filterobject`
picnixz Dec 23, 2024
96a0c4e
fix UBSan failures for `mapobject`
picnixz Dec 23, 2024
b48e4aa
fix UBSan failures for `zipobject`
picnixz Dec 23, 2024
d940ada
fix indentation
picnixz Dec 26, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Next Next commit
fix UBSan failures for filterobject
  • Loading branch information
@picnixz
picnixz committed Dec 23, 2024
commit 52300005352875cfaf4f54c2b452f6c51f9de914
24 changes: 15 additions & 9 deletions Python/bltinmodule.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -494,6 +494,8 @@ typedef struct {
PyObject *it;
} filterobject;

#define _filterobject_CAST(op) ((filterobject *)(op))

static PyObject *
filter_new(PyTypeObject *type, PyObject *args, PyObject *kwds)
{
Expand Down Expand Up @@ -559,8 +561,9 @@ filter_vectorcall(PyObject *type, PyObject * const*args,
}

static void
filter_dealloc(filterobject *lz)
filter_dealloc(PyObject *self)
{
filterobject *lz = _filterobject_CAST(self);
PyObject_GC_UnTrack(lz);
Py_TRASHCAN_BEGIN(lz, filter_dealloc)
Py_XDECREF(lz->func);
Expand All @@ -570,16 +573,18 @@ filter_dealloc(filterobject *lz)
}

static int
filter_traverse(filterobject *lz, visitproc visit, void *arg)
filter_traverse(PyObject *self, visitproc visit, void *arg)
{
filterobject *lz = _filterobject_CAST(self);
Py_VISIT(lz->it);
Py_VISIT(lz->func);
return 0;
}

static PyObject *
filter_next(filterobject *lz)
filter_next(PyObject *self)
{
filterobject *lz = _filterobject_CAST(self);
PyObject *item;
PyObject *it = lz->it;
long ok;
Expand Down Expand Up @@ -613,15 +618,16 @@ filter_next(filterobject *lz)
}

static PyObject *
filter_reduce(filterobject *lz, PyObject *Py_UNUSED(ignored))
filter_reduce(PyObject *self, PyObject *Py_UNUSED(ignored))
{
filterobject *lz = _filterobject_CAST(self);
return Py_BuildValue("O(OO)", Py_TYPE(lz), lz->func, lz->it);
}

PyDoc_STRVAR(reduce_doc, "Return state information for pickling.");

static PyMethodDef filter_methods[] = {
{"__reduce__", _PyCFunction_CAST(filter_reduce), METH_NOARGS, reduce_doc},
{"__reduce__", filter_reduce, METH_NOARGS, reduce_doc},
{NULL, NULL} /* sentinel */
};

Expand All @@ -638,7 +644,7 @@ PyTypeObject PyFilter_Type = {
sizeof(filterobject), /* tp_basicsize */
0, /* tp_itemsize */
/* methods */
(destructor)filter_dealloc, /* tp_dealloc */
filter_dealloc, /* tp_dealloc */
0, /* tp_vectorcall_offset */
0, /* tp_getattr */
0, /* tp_setattr */
Expand All @@ -656,12 +662,12 @@ PyTypeObject PyFilter_Type = {
Py_TPFLAGS_DEFAULT | Py_TPFLAGS_HAVE_GC |
Py_TPFLAGS_BASETYPE, /* tp_flags */
filter_doc, /* tp_doc */
(traverseproc)filter_traverse, /* tp_traverse */
filter_traverse, /* tp_traverse */
0, /* tp_clear */
0, /* tp_richcompare */
0, /* tp_weaklistoffset */
PyObject_SelfIter, /* tp_iter */
(iternextfunc)filter_next, /* tp_iternext */
filter_next, /* tp_iternext */
filter_methods, /* tp_methods */
0, /* tp_members */
0, /* tp_getset */
Expand All @@ -674,7 +680,7 @@ PyTypeObject PyFilter_Type = {
PyType_GenericAlloc, /* tp_alloc */
filter_new, /* tp_new */
PyObject_GC_Del, /* tp_free */
.tp_vectorcall = (vectorcallfunc)filter_vectorcall
.tp_vectorcall = filter_vectorcall
};


Expand Down