Skip to content

gh-128863: deprecate _PyLong_FromDigits() function #127939

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
vstinner merged 6 commits into from
Jan 24, 2025
Merged

gh-128863: deprecate _PyLong_FromDigits() function #127939

Changes from 1 commit
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
98242b4
gh-127937: deprecate _PyLong_FromDigits() function
skirpichev Dec 14, 2024
ebb5693
Merge branch 'master' into deprecate-_PyLong_FromDigits/127937
skirpichev Jan 24, 2025
1b80350
address review: inline _PyLong_FromDigits & improve docs
skirpichev Jan 24, 2025
d5e1fef
+1
skirpichev Jan 24, 2025
39ed5ea
Merge branch 'main' into deprecate-_PyLong_FromDigits/127937
skirpichev Jan 24, 2025
4e76622
address review: remove PyErr_NoMemory()
skirpichev Jan 24, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
+1
  • Loading branch information
@skirpichev
skirpichev committed Jan 24, 2025
commit d5e1fefc35d10e729ac7524f919e51146db445e2
10 changes: 8 additions & 2 deletions Objects/longobject.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -217,12 +217,17 @@ PyObject *
_PyLong_Copy(PyLongObject *src)
{
assert(src != NULL);
int sign;

if (_PyLong_IsCompact(src)) {
stwodigits ival = medium_value(src);
if (IS_SMALL_INT(ival)) {
return get_small_int((sdigit)ival);
}
sign = _PyLong_CompactSign(src);
}
else {
sign = _PyLong_NonCompactSign(src);
}

Py_ssize_t size = _PyLong_DigitCount(src);
Expand All @@ -232,8 +237,9 @@ _PyLong_Copy(PyLongObject *src)
PyErr_NoMemory();
Comment thread
skirpichev marked this conversation as resolved.
Outdated
return NULL;
}
_PyLong_SetSignAndDigitCount(result, _PyLong_Sign(src), size);
memcpy(result->long_value.ob_digit, src->long_value.ob_digit, size * sizeof(digit));
_PyLong_SetSignAndDigitCount(result, sign, size);
memcpy(result->long_value.ob_digit, src->long_value.ob_digit,
size * sizeof(digit));
return (PyObject *)result;
}

Expand Down