Skip to content

bpo-20180: Use argument clinic for dict.pop() and dict.popitem() #12792

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
methane merged 5 commits into from
Apr 12, 2019
Merged

bpo-20180: Use argument clinic for dict.pop() and dict.popitem() #12792

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
6355604
clinic: dict.pop()
methane Apr 12, 2019
8320c7e
clinic: dict.popitem()
methane Apr 12, 2019
c32ca13
run clinic
methane Apr 12, 2019
c164150
update dict.popitem() docstring
methane Apr 12, 2019
aeca91c
add NEWS entry
methane Apr 12, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
update dict.popitem() docstring
  • Loading branch information
@methane
methane committed Apr 12, 2019
commit c1641501fb2dc87d362a843778a12ddf9e8ccfc6
5 changes: 3 additions & 2 deletions Objects/clinic/dictobject.c.h
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

5 changes: 3 additions & 2 deletions Objects/dictobject.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3007,14 +3007,15 @@ dict_pop_impl(PyDictObject *self, PyObject *key, PyObject *default_value)
/*[clinic input]
dict.popitem

Remove and return some (key, value) pair as a 2-tuple.
Remove and return a (key, value) pair as a 2-tuple.

Pairs are returned in LIFO (last-in, first-out) order.
Raises KeyError if the dict is empty.
[clinic start generated code]*/

static PyObject *
dict_popitem_impl(PyDictObject *self)
/*[clinic end generated code: output=e65fcb04420d230d input=d8f2b7a50b271c28]*/
/*[clinic end generated code: output=e65fcb04420d230d input=1c38a49f21f64941]*/
{
Py_ssize_t i, j;
PyDictKeyEntry *ep0, *ep;
Expand Down