Skip to content

gh-115999: Specialize STORE_ATTR in free-threaded builds. #127838

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
nascheme merged 12 commits into from
Dec 19, 2024
Merged

gh-115999: Specialize STORE_ATTR in free-threaded builds. #127838

Changes from 1 commit
Commits
Show all changes
12 commits
Select commit Hold shift + click to select a range
083cbe9
Enable specialization of `STORE_ATTR` free-threaded builds.
nascheme Dec 2, 2024
62c8197
Fix issues found in code review.
nascheme Dec 13, 2024
6fb6e4a
Small optimization for STORE_ATTR specialize.
nascheme Dec 13, 2024
75d9a53
Fix race in specialize_dict_access_inline().
nascheme Dec 13, 2024
476058d
Use correct type of load for tp_version_tag.
nascheme Dec 13, 2024
756f939
Avoid overwritting 'dict', needed for unlock.
nascheme Dec 13, 2024
104d972
Add additional tests for STORE_ATTR.
nascheme Dec 13, 2024
4981652
Remove unneeded atomic load.
nascheme Dec 17, 2024
6bf9016
Add locking for split dict keys.
nascheme Dec 17, 2024
9015a3f
Code cleanup, remove unneeded branches.
nascheme Dec 18, 2024
14ae6b4
Merge branch 'main' into gh-115999-specialize-store-attr
nascheme Dec 19, 2024
06a7baf
Merge branch 'main' into gh-115999-specialize-store-attr
nascheme Dec 19, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Remove unneeded atomic load. 
The function is only used in with-GIL builds.
  • Loading branch information
@nascheme
nascheme committed Dec 18, 2024
commit 4981652bcf3ef2e31c0e7d8c415d1c306d34dc8f
2 changes: 1 addition & 1 deletion Python/specialize.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1774,7 +1774,7 @@ function_get_version(PyObject *o, int opcode)
static uint32_t
type_get_version(PyTypeObject *t, int opcode)
{
uint32_t version = FT_ATOMIC_LOAD_UINT_RELAXED(t->tp_version_tag);
uint32_t version = t->tp_version_tag;
if (version == 0) {
SPECIALIZATION_FAIL(opcode, SPEC_FAIL_OUT_OF_VERSIONS);
return 0;
Expand Down