Skip to content

gh-127691: add type checks when using PyUnicodeError objects #127694

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
encukou merged 13 commits into from
Dec 13, 2024
Merged

gh-127691: add type checks when using PyUnicodeError objects #127694

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
13 commits
Select commit Hold shift + click to select a range
bd07ea4
add type checks when using `PyUnicodeError` objects
picnixz Dec 6, 2024
21bcef2
reduce un-necessary casts
picnixz Dec 6, 2024
17d2665
fix check
picnixz Dec 6, 2024
bac5031
fix tests
picnixz Dec 6, 2024
37655a2
blurb
picnixz Dec 6, 2024
af7e7bb
fix typo
picnixz Dec 6, 2024
a8bfd70
fix refs
picnixz Dec 6, 2024
0ec814e
Update CHANGELOG
picnixz Dec 7, 2024
7c7d20c
Apply suggestions from code review
picnixz Dec 7, 2024
49a32cf
Update Objects/exceptions.c
picnixz Dec 7, 2024
a5ee3d0
Update Objects/exceptions.c
picnixz Dec 7, 2024
7fe6e67
Fix English
picnixz Dec 7, 2024
970720a
Improve wording
picnixz Dec 7, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Fix English
  • Loading branch information
@picnixz
picnixz authored Dec 7, 2024
commit 7fe6e6711d60145c0dbe83c85502f53474aa553e
2 changes: 1 addition & 1 deletion Doc/whatsnew/3.14.rst
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1028,7 +1028,7 @@ New features
deferred reference counting, as outlined in :pep:`703`.

* The :ref:`Unicode Exception Objects <unicodeexceptions>` C API
now raises :exc:`TypeError` if its exception argument is not an
now raises a :exc:`TypeError` if its exception argument is not a
:exc:`UnicodeError`.
(Contributed by Bénédikt Tran in :gh:`127691`.)

Expand Down
2 changes: 1 addition & 1 deletion Misc/NEWS.d/next/C_API/2024-12-06-16-53-34.gh-issue-127691.k_Jitp.rst
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,3 +1,3 @@
The :ref:`Unicode Exception Objects <unicodeexceptions>` C API
now raises :exc:`TypeError` if its exception argument is not an
now raises a :exc:`TypeError` if its exception argument is not a
:exc:`UnicodeError`. Patch by Bénédikt Tran.