Skip to content

gh-126004: remove redundant safeguards for codecs handlers tests #127680

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
picnixz merged 5 commits into from
Jan 23, 2025
Merged

gh-126004: remove redundant safeguards for codecs handlers tests #127680

Changes from 1 commit
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
ce397ae
allow to mark codecs handlers tests as safe
picnixz Dec 6, 2024
2216181
upgrade tests
picnixz Dec 6, 2024
1f543c7
Merge branch 'main' into fix/codecs/safe-handlers-126004
picnixz Jan 23, 2025
d6bc869
remove redundant safeguards
picnixz Jan 23, 2025
2e7f323
add double blank line
picnixz Jan 23, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
20 changes: 15 additions & 5 deletions Lib/test/test_capi/test_codecs.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -835,7 +835,8 @@ def test_codec_strict_errors_handler(self):

def test_codec_ignore_errors_handler(self):
handler = _testcapi.codec_ignore_errors
self.do_test_codec_errors_handler(handler, self.all_unicode_errors)
self.do_test_codec_errors_handler(handler, self.all_unicode_errors,
safe=True)

def test_codec_replace_errors_handler(self):
handler = _testcapi.codec_replace_errors
Expand All @@ -851,20 +852,29 @@ def test_codec_backslashreplace_errors_handler(self):

def test_codec_namereplace_errors_handler(self):
handler = _testlimitedcapi.codec_namereplace_errors
self.do_test_codec_errors_handler(handler, self.unicode_encode_errors)
self.do_test_codec_errors_handler(handler, self.unicode_encode_errors,
safe=True)

def do_test_codec_errors_handler(self, handler, exceptions):
def do_test_codec_errors_handler(self, handler, exceptions, *, safe=False):
at_least_one = False
for exc in exceptions:
# See https://github.com/python/cpython/issues/123378 and related
# discussion and issues for details.
if self._exception_may_crash(exc):
if not safe and self._exception_may_crash(exc):
continue

at_least_one = True
with self.subTest(handler=handler, exc=exc):
# test that the handler does not crash
self.assertIsInstance(handler(exc), tuple)
res = handler(exc)
self.assertIsInstance(res, tuple)
self.assertEqual(len(res), 2)
Comment thread
picnixz marked this conversation as resolved.
self.assertIsInstance(res[0], str)
# We only check the type of res[1] but not its range since
# it depends on *_GetStart() and *_GetEnd() functions which
# automatically clip the 'start' and 'end' values (possibly
# negative or inconsistent).
self.assertIsInstance(res[1], int)

if exceptions:
self.assertTrue(at_least_one, "all exceptions are crashing")
Expand Down