Skip to content

GH-127456: pathlib ABCs: add protocol for path parser #127494

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
barneygale merged 12 commits into from
Dec 9, 2024
Merged

GH-127456: pathlib ABCs: add protocol for path parser #127494

Changes from 1 commit
Commits
Show all changes
12 commits
Select commit Hold shift + click to select a range
f5e946b
Change the default value of `PurePathBase.parser` from `ParserBase()` to
barneygale Nov 30, 2024
9febad0
Move `pathlib._abc.ParserBase` to `pathlib._types.Parser`, and conver…
barneygale Nov 30, 2024
6e07a3c
Add `pathlib._types.DirEntry`, which is a protocol for directory entr…
barneygale Nov 30, 2024
2ada5d1
Add `pathlib._types.StatResult`, which is a protocol for stat() results.
barneygale Nov 30, 2024
0d0140a
Revise tests
barneygale Nov 30, 2024
4d51683
Docstring tweaks
barneygale Dec 1, 2024
59201c3
Apply suggestions from code review
barneygale Dec 3, 2024
2fa207c
Add DirEntry.is_file()
barneygale Dec 3, 2024
137875c
Another docstring tweak
barneygale Dec 3, 2024
0cc51fa
Merge branch 'main' into gh-127456
barneygale Dec 7, 2024
ee23e0e
Remove DirEntry and StatResult for now.
barneygale Dec 7, 2024
d3fbc5b
Merge branch 'main' into gh-127456
barneygale Dec 9, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Apply suggestions from code review 
Co-authored-by: Bénédikt Tran <10796600+picnixz@users.noreply.github.com>
  • Loading branch information
@barneygale @picnixz
barneygale and picnixz authored Dec 3, 2024
commit 59201c3709494eca2621fc01f5cff24b36896121
9 changes: 5 additions & 4 deletions Lib/pathlib/_types.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,9 +15,9 @@ class Parser(Protocol):

sep: str
Comment thread
barneygale marked this conversation as resolved.
def join(self, path: str, *paths: str) -> str: ...
def split(self, path: str) -> (str, str): ...
def splitdrive(self, path: str) -> (str, str): ...
def splitext(self, path: str) -> (str, str): ...
def split(self, path: str) -> tuple[str, str]: ...
def splitdrive(self, path: str) -> tuple[str, str]: ...
def splitext(self, path: str) -> tuple[str, str]: ...
def normcase(self, path: str) -> str: ...
def isabs(self, path: str) -> bool: ...

Expand Down Expand Up @@ -47,7 +47,8 @@ class StatResult(Protocol):
files.

Stat results provide a subset of the os.stat_result API, specifically
attributes for the file type, permissions and offset."""
attributes for the file type, permissions and offset.
"""

st_mode: int
st_ino: int
Expand Down