Repository navigation
gh-109798: Normalize _datetime and datetime error messages
#127345
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from 1 commit
Commits
Show all changes
31 commits
Select commit
Hold shift + click to select a range
764eb1b
Update error messages to be the same in datetime
donbarbos 2bf419f
Add NEWS.d/next
donbarbos 4363e9e
fixed syntax errors
donbarbos 9da0dfc
Move Py_DECREF after PyErr_Format
donbarbos 179423d
Add more info in message error in _pydatetime impl
donbarbos f691251
Update Modules/_datetimemodule.c
donbarbos d8973cf
Update Modules/_datetimemodule.c
donbarbos 5eea62f
Update Modules/_datetimemodule.c
donbarbos 79543cc
Update Modules/_datetimemodule.c for optimisation
donbarbos d174497
Revert last update Modules/_datetimemodule.c
donbarbos 498c4ba
Update Modules/_datetimemodule.c
donbarbos 216d0fe
Update Misc/NEWS.d message
donbarbos c409fec
Update Misc/NEWS.d message
donbarbos 3f454f6
Update Misc/NEWS.d message
donbarbos a2b8f7a
Update Misc/NEWS.d message
donbarbos 209c338
Update Lib/_pydatetime.py
donbarbos 0777aa5
Update Misc/NEWS.d/next/Library/2024-11-27-23-29-05.gh-issue-109798.O…
donbarbos 4d31d33
Update Lib/_pydatetime.py
donbarbos f05ebba
Update Lib/_pydatetime.py
donbarbos f840105
Update Lib/_pydatetime.py
donbarbos 61c95a5
Update Lib/_pydatetime.py
donbarbos 2ab77b3
Update Lib/_pydatetime.py
donbarbos b1e272a
Update Lib/_pydatetime.py
donbarbos 7a35bd4
Update Lib/_pydatetime.py
donbarbos cfd18cb
Add tests
donbarbos 2827514
Update _pydatetime.py
donbarbos cd3bdc1
Update _pydatetime.py
donbarbos 9915dfe
Change but got to not
donbarbos 1da5a3a
Correct line break
donbarbos 610f067
Update 2024-11-27-23-29-05.gh-issue-109798.OPj1CT.rst
pganssle 410e0ce
Merge branch 'main' into issue-109798
pganssle File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Update Misc/NEWS.d message
- Loading branch information
commit a2b8f7afc87f3cb9fe972f6554e3699c4df45dfd
There are no files selected for viewing
4 changes: 2 additions & 2 deletions
4
Misc/NEWS.d/next/Library/2024-11-27-23-29-05.gh-issue-109798.OPj1CT.rst
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,2 +1,2 @@ | ||
| Normalized error messages for both implementations of :mod:`datetime`. Made more | ||
| detailed error messages showing input values. Patch by Semyon Moroz. | ||
| Normalized error messages for both implementations of :mod:`datetime`. Made | ||
| more detailed error messages showing input values. Patch by Semyon Moroz. | ||
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.