Skip to content

bpo-31904: Skip setting RLIMIT_FSIZE and RLIMIT_CPU test case for VxWorks #12719

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
vstinner merged 4 commits into from
Apr 17, 2019
Merged

bpo-31904: Skip setting RLIMIT_FSIZE and RLIMIT_CPU test case for VxWorks #12719

Show file tree
Hide file tree
Changes from 3 commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
b3ccba9
bpo-31904: skip test case in test_resource for VxWorks doesn't support
LihuaZhao Apr 8, 2019
3d49a70
add news file
LihuaZhao Apr 8, 2019
90f6ce7
skip LIMIT_FSIZE and RLIMIT_CPU full function test
LihuaZhao Apr 17, 2019
647cefb
move the NEWS to Test directory and update document
LihuaZhao Apr 17, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions Doc/library/resource.rst
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -76,6 +76,8 @@ this module for those platforms.
``setrlimit`` may also raise :exc:`error` if the underlying system call
fails.

VxWorks only support setting RLIMIT_NOFILE and idtype must be P_PID.

@vstinner vstinner Apr 17, 2019

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

"supports" with a S, no? (I'm not sure, English is not my first language!) Please use :data: to format properly the RLIMIT_NOFILE constant.

Suggested change
VxWorks only support setting RLIMIT_NOFILE and idtype must be P_PID.
VxWorks only supports setting :data:`RLIMIT_NOFILE` and idtype must be P_PID.

I don't understand "idtype must be P_PID": what does it mean? Is it something specific to VxWorks?

@LihuaZhao LihuaZhao Apr 17, 2019

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, it's VxWorks specific requires.

@LihuaZhao LihuaZhao Apr 17, 2019

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I remove that statements for python user doesn't need to care about it.


.. function:: prlimit(pid, resource[, limits])

Combines :func:`setrlimit` and :func:`getrlimit` in one function and
Expand Down
4 changes: 4 additions & 0 deletions Lib/test/test_resource.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,6 +16,8 @@ def test_args(self):
self.assertRaises(TypeError, resource.setrlimit)
self.assertRaises(TypeError, resource.setrlimit, 42, 42, 42)

@unittest.skipIf(sys.platform == "vxworks",
"setting RLIMIT_FSIZE is not supported on VxWorks")
def test_fsize_ismax(self):
try:
(cur, max) = resource.getrlimit(resource.RLIMIT_FSIZE)
Expand Down Expand Up @@ -110,6 +112,8 @@ def test_getrusage(self):
pass

# Issue 6083: Reference counting bug
@unittest.skipIf(sys.platform == "vxworks",
"setting RLIMIT_CPU is not supported on VxWorks")
def test_setrusage_refcount(self):
try:
limits = resource.getrlimit(resource.RLIMIT_CPU)
Expand Down
1 change: 1 addition & 0 deletions Misc/NEWS.d/next/Library/2019-04-08-09-24-36.bpo-31904.ab03ea.rst
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
Skip setting RLIMIT_FSIZE and RLIMIT_CPU test case for VxWorks

@vstinner vstinner Apr 17, 2019

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please move this NEWS entry to the Misc/NEWS.d/next/Tests/ directory, and mention the name of the fixed test, for example:

Port test_resource to VxWorks: skip tests cases setting RLIMIT_FSIZE and RLIMIT_CPU.