Skip to content

gh-127041: Prevent new threads after an interpreter has started finalizing #127044

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
ZeroIntensity wants to merge 6 commits into from
Closed

gh-127041: Prevent new threads after an interpreter has started finalizing #127044

Changes from 1 commit
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
a3c40b0
Initial implementation.
ZeroIntensity Nov 19, 2024
b2feff8
Add a test.
ZeroIntensity Nov 19, 2024
0b14894
Remove dead code.
ZeroIntensity Nov 19, 2024
fe57506
It seems that code was less dead than I thought.
ZeroIntensity Nov 19, 2024
99f6e74
Temporarily disable test.
ZeroIntensity Nov 19, 2024
afdc649
Update pystate.c
ZeroIntensity Nov 20, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Add a test.
  • Loading branch information
@ZeroIntensity
ZeroIntensity committed Nov 19, 2024
commit b2feff877a6cdf9ffceb36199cab0d0f9a3a5bde
27 changes: 27 additions & 0 deletions Lib/test/test_interpreters/test_stress.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -62,6 +62,33 @@ def run():
with threading_helper.start_threads(threads):
pass

def test_many_threads_running_and_destroying(self):
interp = interpreters.create()

def run():
try:
interp.exec("1")
interp.close()
except Exception as e:
# Ignore all interpreter errors, we just want to make
# sure that it doesn't crash
self.assertIsInstance(
e,
(
interpreters.ExecutionFailed,
interpreters.InterpreterNotFoundError,
interpreters.InterpreterError
)
)

threads = (threading.Thread(target=run) for _ in range(200))
with threading_helper.catch_threading_exception() as cm:
with threading_helper.start_threads(threads):
pass

self.assertIsNone(cm.exc_value)



if __name__ == '__main__':
# Test needs to be a package, so we can do relative imports.
Expand Down