Skip to content

gh-126599: Refactor the _PyOptimizer APIs #126853

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
brandtbucher merged 18 commits into from
Jan 16, 2025
Merged

gh-126599: Refactor the _PyOptimizer APIs #126853

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
18 commits
Select commit Hold shift + click to select a range
a5bd3f1
remove `_PyOptimizer_NewCounter`
xuantengh Nov 11, 2024
a77915c
remove uop optimize tests
xuantengh Nov 15, 2024
089f2b9
remove `_PyOptimizer_NewUOpOptimizer`
xuantengh Nov 15, 2024
16681b0
revert commits
xuantengh Nov 15, 2024
68dd2b1
add export explanation
xuantengh Nov 15, 2024
f3542b6
remove `_PyCounterOptimizer_Type` and `_PyOptimizer_NewCounter`
xuantengh Nov 23, 2024
d763008
📜🤖 Added by blurb_it.
blurb-it[bot] Jan 1, 2025
a7f9df3
remove `_INTERNAL_INCREMENT_OPT_COUNTER`
xuantengh Jan 12, 2025
44aa7ab
remove `_PyCounterOptimizerObject`
xuantengh Jan 12, 2025
0e96ecb
remove misc. stuff
xuantengh Jan 12, 2025
ce188a4
Update Misc/NEWS.d/next/C_API/2025-01-01-03-25-38.gh-issue-126599.MRC…
xuantengh Jan 12, 2025
949352e
remove unnecessary comments
xuantengh Jan 14, 2025
46f0fa6
re-gen cases
xuantengh Jan 14, 2025
f0ffafd
fix capi test failures
xuantengh Jan 14, 2025
85580ca
add decorator for required API
xuantengh Jan 14, 2025
c3f4c6b
Clean up the diff
brandtbucher Jan 16, 2025
fcb9d07
Fix some unused code warnings
brandtbucher Jan 16, 2025
f67555f
Catch up with main
brandtbucher Jan 16, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
remove _PyOptimizer_NewUOpOptimizer
  • Loading branch information
@xuantengh
xuantengh committed Jan 14, 2025
commit 089f2b91e8711dc66ebe6e6541dd6dce85782748
2 changes: 1 addition & 1 deletion Include/internal/pycore_optimizer.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -119,7 +119,7 @@ PyAPI_FUNC(void) _Py_Executor_DependsOn(_PyExecutorObject *executor, void *obj);
// Export for '_testinternalcapi' shared extension.
PyAPI_FUNC(_PyOptimizerObject *) _Py_GetOptimizer(void);
PyAPI_FUNC(int) _Py_SetTier2Optimizer(_PyOptimizerObject* optimizer);
PyAPI_FUNC(PyObject *) _PyOptimizer_NewUOpOptimizer(void);
PyAPI_FUNC(void) _Py_SetUOpOptimize(_PyOptimizerObject* opt);

#define _Py_MAX_ALLOWED_BUILTINS_MODIFICATIONS 3
#define _Py_MAX_ALLOWED_GLOBALS_MODIFICATIONS 6
Expand Down
9 changes: 2 additions & 7 deletions Python/optimizer.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1321,15 +1321,10 @@ PyTypeObject _PyUOpOptimizer_Type = {
.tp_dealloc = uop_opt_dealloc,
};

PyObject *
_PyOptimizer_NewUOpOptimizer(void)
void
_Py_SetUOpOptimize(_PyOptimizerObject *opt)
{
_PyOptimizerObject *opt = PyObject_New(_PyOptimizerObject, &_PyUOpOptimizer_Type);
if (opt == NULL) {
return NULL;
}
opt->optimize = uop_optimize;
return (PyObject *)opt;
}

static void
Expand Down
3 changes: 2 additions & 1 deletion Python/pylifecycle.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1351,10 +1351,11 @@ init_interp_main(PyThreadState *tstate)
} else
#endif
{
PyObject *opt = _PyOptimizer_NewUOpOptimizer();
PyObject *opt = PyObject_New(_PyOptimizerObject, &_PyUOpOptimizer_Type);
if (opt == NULL) {
return _PyStatus_ERR("can't initialize optimizer");
}
_Py_SetUOpOptimize((_PyOptimizerObject *)opt);
Comment thread
xuantengh marked this conversation as resolved.
Outdated
if (_Py_SetTier2Optimizer((_PyOptimizerObject *)opt)) {
return _PyStatus_ERR("can't install optimizer");
}
Expand Down