Skip to content

gh-115999: Add free-threaded specialization for TO_BOOL #126616

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
corona10 merged 17 commits into from
Nov 21, 2024
Merged

gh-115999: Add free-threaded specialization for TO_BOOL #126616

Changes from 1 commit
Commits
Show all changes
17 commits
Select commit Hold shift + click to select a range
62b0307
gh-115999: Add free-threaded specialization for ``TO_BOOL``
corona10 Nov 9, 2024
e32f2f0
nit
corona10 Nov 9, 2024
6798366
Make set cache as atomic operation
corona10 Nov 9, 2024
e45778b
fix
corona10 Nov 9, 2024
bafabd7
fix
corona10 Nov 9, 2024
aa8a81c
nit
corona10 Nov 9, 2024
1f4a350
Address code review
corona10 Nov 10, 2024
23e190e
Address code review
corona10 Nov 10, 2024
30020b9
Address code review
corona10 Nov 12, 2024
b1f1c71
Update comments
corona10 Nov 12, 2024
a213390
Merge remote-tracking branch 'upstream/main' into gh-115999-bool
corona10 Nov 16, 2024
e68dc65
Address code review
corona10 Nov 16, 2024
b27f916
Address code review
corona10 Nov 16, 2024
249efd1
nit
corona10 Nov 16, 2024
c08f8b7
Merge remote-tracking branch 'upstream/main' into gh-115999-bool
corona10 Nov 21, 2024
6bc4c90
Address code review
corona10 Nov 21, 2024
542e4dd
Use TO_BOOL for SPECIALIZATION_FAIL
corona10 Nov 21, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Address code review
  • Loading branch information
@corona10
corona10 committed Nov 16, 2024
commit e68dc65b363a3496e350191869b9f02635ddada5
28 changes: 16 additions & 12 deletions Python/specialize.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2716,25 +2716,26 @@ _Py_Specialize_ToBool(_PyStackRef value_o, _Py_CODEUNIT *instr)
assert(_PyOpcode_Caches[TO_BOOL] == INLINE_CACHE_ENTRIES_TO_BOOL);
_PyToBoolCache *cache = (_PyToBoolCache *)(instr + 1);
PyObject *value = PyStackRef_AsPyObjectBorrow(value_o);
uint8_t specialized_op;
if (PyBool_Check(value)) {
specialize(instr, TO_BOOL_BOOL);
return;
specialized_op = TO_BOOL_BOOL;
goto success;
}
if (PyLong_CheckExact(value)) {
specialize(instr, TO_BOOL_INT);
return;
specialized_op = TO_BOOL_INT;
goto success;
}
if (PyList_CheckExact(value)) {
specialize(instr, TO_BOOL_LIST);
return;
specialized_op = TO_BOOL_LIST;
goto success;
}
if (Py_IsNone(value)) {
specialize(instr, TO_BOOL_NONE);
return;
specialized_op = TO_BOOL_NONE;
goto success;
}
if (PyUnicode_CheckExact(value)) {
specialize(instr, TO_BOOL_STR);
return;
specialized_op = TO_BOOL_STR;
goto success;
}
if (PyType_HasFeature(Py_TYPE(value), Py_TPFLAGS_HEAPTYPE)) {
unsigned int version = 0;
Expand All @@ -2751,10 +2752,13 @@ _Py_Specialize_ToBool(_PyStackRef value_o, _Py_CODEUNIT *instr)
assert(err == 0);
assert(version);
write_u32(cache->version, version);
specialize(instr, TO_BOOL_ALWAYS_TRUE);
return;
specialized_op = TO_BOOL_ALWAYS_TRUE;
goto success;
}
unspecialize(instr, to_bool_fail_kind(value));
return;
success:
specialize(instr, specialized_op);
}

static int
Expand Down