Skip to content

gh-115999: Specialize LOAD_GLOBAL in free-threaded builds #126607

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
mpage merged 19 commits into from
Nov 21, 2024
Merged

gh-115999: Specialize LOAD_GLOBAL in free-threaded builds #126607

Changes from 1 commit
Commits
Show all changes
19 commits
Select commit Hold shift + click to select a range
05af6b2
Make specialization of LOAD_GLOBAL thread-safe
mpage Sep 25, 2024
5af633c
_Py_GetExecutor needs a CS in free-threaded builds
mpage Oct 28, 2024
7b3df6f
Undo workaround for cases generator bug
mpage Nov 8, 2024
8f6239d
Fix unused function warning
mpage Nov 8, 2024
49ec70a
Double check that keys are still valid
mpage Nov 8, 2024
0e50451
Fix formatting
mpage Nov 8, 2024
72519ca
Fix linkage
mpage Nov 9, 2024
d55397b
`_Py_TryIncrefCompare` can't escape
mpage Nov 9, 2024
ad9a9d0
Use atomics for setting keys version for split keys
mpage Nov 16, 2024
5b7e65c
Ensure dict is shared when assigning keys version
mpage Nov 16, 2024
129300b
Don't check keys after loading them
mpage Nov 17, 2024
3440429
Support deferred refcounting
mpage Nov 17, 2024
01041a4
Merge branch 'main' into gh-115999-tlbc-load-global
mpage Nov 18, 2024
bfe1c93
Fix param name
mpage Nov 19, 2024
d5258e0
Always mark keys shared
mpage Nov 19, 2024
852be38
Update comment
mpage Nov 19, 2024
e11e0ae
Merge branch 'main' into gh-115999-tlbc-load-global
mpage Nov 20, 2024
01f4143
Don't pass reason to unspecialize
mpage Nov 20, 2024
b922dfe
Merge branch 'main' into gh-115999-tlbc-load-global
mpage Nov 21, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Fix formatting
  • Loading branch information
@mpage
mpage committed Nov 8, 2024
commit 0e5045149ce1d061e5c78bce892a6851de954163
6 changes: 4 additions & 2 deletions Objects/dictobject.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7402,11 +7402,13 @@ uint32_t _PyDictKeys_GetVersionForCurrentState(PyInterpreterState *interp,
#ifdef Py_GIL_DISABLED
uint32_t v;
do {
v = _Py_atomic_load_uint32_relaxed(&interp->dict_state.next_keys_version);
v = _Py_atomic_load_uint32_relaxed(
&interp->dict_state.next_keys_version);
if (v == 0) {
return 0;
}
} while(!_Py_atomic_compare_exchange_uint32(&interp->dict_state.next_keys_version, &v, v + 1));
} while (!_Py_atomic_compare_exchange_uint32(
&interp->dict_state.next_keys_version, &v, v + 1));
#else
if (interp->dict_state.next_keys_version == 0) {
return 0;
Expand Down