Skip to content

Incremental "mark alive" pass for cyclic GC #126511

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
nascheme wants to merge 7 commits into from
Closed

Incremental "mark alive" pass for cyclic GC #126511

Changes from 1 commit
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
bbbe019
wip: mark alive with list
nascheme Oct 19, 2024
4940097
wip: progress
nascheme Oct 20, 2024
84d4053
wip: working
nascheme Oct 20, 2024
4f69ead
wip: add timing stats
nascheme Oct 21, 2024
04c2dbf
wip: improve comments
nascheme Oct 21, 2024
ec98e57
wip: add timing stats for full collections
nascheme Oct 21, 2024
12ceba2
Add WITH_GC_MARK_ALIVE and WITH_GC_TIMING_STATS
nascheme Oct 23, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
wip: add timing stats for full collections
  • Loading branch information
@nascheme
nascheme committed Oct 21, 2024
commit ec98e5785969e69c365b394d04622b48540d11c1
17 changes: 13 additions & 4 deletions Python/gc.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -244,7 +244,9 @@ int main() {
}
#endif

P2Engine gc_timing;
// timings for automatic collections
P2Engine gc_timing; // all automatic collections
P2Engine gc_timing_full; // full (gen2) automatic collections

#endif // gc timing

Expand Down Expand Up @@ -363,6 +365,7 @@ _PyGC_Init(PyInterpreterState *interp)
}

p2engine_init(&gc_timing, gc_timing_quantiles);
p2engine_init(&gc_timing_full, gc_timing_quantiles);

return _PyStatus_OK();
}
Expand Down Expand Up @@ -1408,7 +1411,7 @@ maybe_mark_alive(PyThreadState *tstate, int generation, _PyGC_Reason reason)
else {
if (generation == OLD_GENERATION) {
float f = ((float)gcstate->mark_state.old_alive_size) / gcstate->mark_state.old_size;
fprintf(stderr, "gc full auto collection %.2f\n", f);
fprintf(stderr, "gc full auto collection, alive fraction=%.2f\n", f);
fprintf(stderr, "gc steps needed=%d available=%d\n", gcstate->mark_state.mark_steps, gcstate->mark_state.mark_steps_total);
print_gc_times(gcstate);
gcstate->mark_state.mark_phase = MARK_PHASE_INIT;
Expand Down Expand Up @@ -1853,6 +1856,9 @@ gc_collect_main(PyThreadState *tstate, int generation, _PyGC_Reason reason)
dt = t3 - t1;
if (reason == _Py_GC_REASON_HEAP) {
p2engine_add(&gc_timing, (double)_PyTime_AsMicroseconds(dt, _PyTime_ROUND_HALF_EVEN));
if (generation == OLD_GENERATION) {
p2engine_add(&gc_timing_full, (double)_PyTime_AsMicroseconds(dt, _PyTime_ROUND_HALF_EVEN));
}
if (dt > gcstate->mark_state.gc_max_pause) {
gcstate->mark_state.gc_max_pause = dt;
}
Expand Down Expand Up @@ -2149,9 +2155,12 @@ _PyGC_Fini(PyInterpreterState *interp)
print_gc_times(gcstate);
for (int i = 0; i < QUANTILE_COUNT; i++) {
double result = p2engine_result(&gc_timing, gc_timing_quantiles[i]);
fprintf(stderr, "gc timing Q%.0f: %.2f\n", gc_timing_quantiles[i]*100, result);
fprintf(stderr, "gc timing all Q%.0f: %.2f\n", gc_timing_quantiles[i]*100, result);
}
for (int i = 0; i < QUANTILE_COUNT; i++) {
double result = p2engine_result(&gc_timing_full, gc_timing_quantiles[i]);
fprintf(stderr, "gc timing full Q%.0f: %.2f\n", gc_timing_quantiles[i]*100, result);
}
fprintf(stderr, "gc timing max: %.2f\n", gc_timing.max);

}

Expand Down