Skip to content

bpo-31904 : skip test_cmd_line case for VxWorks doesn't support preexec #12648

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
vstinner merged 6 commits into from
Apr 17, 2019
Merged

bpo-31904 : skip test_cmd_line case for VxWorks doesn't support preexec #12648

Show file tree
Hide file tree
Changes from 3 commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
e64be8c
bpo-31904: skip some test case in test_cmd_line for VxWorks doesn't
LihuaZhao Apr 1, 2019
3762b12
add news file
LihuaZhao Apr 1, 2019
48839c2
Move NEWS.d file to test directory
LihuaZhao Apr 17, 2019
700aca1
rework test_cmd_line based on reviewer's comment to use variable inst…
LihuaZhao Apr 17, 2019
d3c2377
update test_cmd_line.py to check vxworks platform directly
LihuaZhao Apr 17, 2019
9195390
recover blank line and delete NEWS
LihuaZhao Apr 17, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions Lib/test/test_cmd_line.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,6 +18,11 @@
# Debug build?
Py_DEBUG = hasattr(sys, "gettotalrefcount")

def _supports_preexec():
if sys.platform == "vxworks":
return False
else:
return True

@vstinner vstinner Apr 17, 2019

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I suggest:

SUBPROCESS_SUPPORTS_PREEXEC = (sys.platform != "vxworks")


@vstinner vstinner Apr 17, 2019

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hum, please revert this unrelated change.

# XXX (ncoghlan): Move to script_helper and make consistent with run_python
def _kill_python_and_exit_code(p):
Expand Down Expand Up @@ -369,6 +374,7 @@ def test_closed_stdout(self):
# Issue #7111: Python should work without standard streams

@unittest.skipIf(os.name != 'posix', "test needs POSIX semantics")
@unittest.skipUnless(_supports_preexec(), "test needs preexec support in subprocess.Popen")
def _test_no_stdio(self, streams):
code = """if 1:
import os, sys
Expand Down
1 change: 1 addition & 0 deletions Misc/NEWS.d/next/Tests/2019-04-01-17-44-36.bpo-31904.32Ef3G.rst
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
Skip test case in test_cmd_line for VxWorks doesn't support preexec when do Popen

@vstinner vstinner Apr 17, 2019

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Honestly, I'm not sure that it's worth it to document invidivual tests changes. Can you please remove the NEWS entry? I will simply add the GitHub label "skip news".