Skip to content

gh-126220: Adapt _lsprof to Argument Clinic #126233

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
sobolevn merged 10 commits into from
Nov 4, 2024
Merged

gh-126220: Adapt _lsprof to Argument Clinic #126233

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
10 commits
Select commit Hold shift + click to select a range
299f63f
gh-126220: Fix crash on calls to `_lsprof.Profiler` methods with 0 args
sobolevn Oct 31, 2024
af78745
Fix CI
sobolevn Oct 31, 2024
3fddc30
Only fix 4 crashers
sobolevn Oct 31, 2024
4ffecdd
Use `instruction_offset` arg name
sobolevn Oct 31, 2024
2b6ecc9
Merge
sobolevn Nov 1, 2024
e3160e3
Convert all methods
sobolevn Nov 1, 2024
3cea189
Apply suggestions from code review
sobolevn Nov 2, 2024
b84dde3
Address review
sobolevn Nov 2, 2024
bf3e120
Typo
sobolevn Nov 2, 2024
0d35f60
Address review
sobolevn Nov 4, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Address review
  • Loading branch information
@sobolevn
sobolevn committed Nov 4, 2024
commit 0d35f6074483fdd94e7485ac1269d8e5391db99a
15 changes: 8 additions & 7 deletions Modules/_lsprof.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -755,20 +755,20 @@ static const struct {
_lsprof.Profiler.enable

subcalls: bool = True
If True, also records for each function
statistics separated according to its current caller.

builtins: bool = True
If True, records the time spent in
built-in functions separately from their caller.

Start collecting profiling information.

If 'subcalls' is True, also records for each function
statistics separated according to its current caller.
If 'builtins' is True, records the time spent in
built-in functions separately from their caller.
[clinic start generated code]*/

static PyObject *
_lsprof_Profiler_enable_impl(ProfilerObject *self, int subcalls,
int builtins)
/*[clinic end generated code: output=1e747f9dc1edd571 input=0b6049b4e398781f]*/
/*[clinic end generated code: output=1e747f9dc1edd571 input=9ab81405107ab7f1]*/
{
int all_events = 0;
if (setSubcalls(self, subcalls) < 0 || setBuiltins(self, builtins) < 0) {
Expand Down Expand Up @@ -953,8 +953,9 @@ profiler_init_impl(ProfilerObject *self, PyObject *timer, double timeunit,
int subcalls, int builtins)
/*[clinic end generated code: output=ac523803ec9f9df2 input=8285ca746f96a414]*/
{
if (setSubcalls(self, subcalls) < 0 || setBuiltins(self, builtins) < 0)
if (setSubcalls(self, subcalls) < 0 || setBuiltins(self, builtins) < 0) {
return -1;
}
self->externalTimerUnit = timeunit;
Py_XSETREF(self->externalTimer, Py_XNewRef(timer));
self->tool_id = PY_MONITORING_PROFILER_ID;
Expand Down
12 changes: 7 additions & 5 deletions Modules/clinic/_lsprof.c.h
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.