Skip to content

gh-125716: Raise an Exception If _globals_init() Fails In the _interpqueues Module #125802

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ericsnowcurrently merged 2 commits into from
Oct 21, 2024
Merged

gh-125716: Raise an Exception If _globals_init() Fails In the _interpqueues Module #125802

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
7d8b9f9
Raise an exception if _globals_init() fails.
ericsnowcurrently Oct 18, 2024
a3bb4ea
Change an incref to a decref.
ericsnowcurrently Oct 21, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Next Next commit
Raise an exception if _globals_init() fails.
  • Loading branch information
@ericsnowcurrently
ericsnowcurrently committed Oct 21, 2024
commit 7d8b9f9e498b578ed11c6c8b129d833488e4fb9c
3 changes: 2 additions & 1 deletion Modules/_interpchannelsmodule.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3482,7 +3482,8 @@ The 'interpreters' module provides a more convenient interface.");
static int
module_exec(PyObject *mod)
{
if (_globals_init() != 0) {
int err = _globals_init();
if (handle_channel_error(err, mod, -1)) {
return -1;
}

Expand Down
3 changes: 2 additions & 1 deletion Modules/_interpqueuesmodule.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1894,7 +1894,8 @@ The 'interpreters' module provides a more convenient interface.");
static int
module_exec(PyObject *mod)
{
if (_globals_init() != 0) {
int err = _globals_init();
if (handle_queue_error(err, mod, -1)) {
return -1;
}

Expand Down