Skip to content

gh-118423: Add INSTRUCTION_SIZE macro to code generator #125467

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
markshannon merged 34 commits into from
Oct 29, 2024
Merged

gh-118423: Add INSTRUCTION_SIZE macro to code generator #125467

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
34 commits
Select commit Hold shift + click to select a range
ec8c701
Add INSTRUCTION_SIZE macro
tomasr8 Oct 14, 2024
09c2f59
Use INSTRUCTION_SIZE in bytecodes.c
tomasr8 Oct 14, 2024
287eb92
Add tests
tomasr8 Oct 14, 2024
c76fce4
Update docs
tomasr8 Oct 14, 2024
e3f3b07
Add news entry
tomasr8 Oct 14, 2024
ed5b375
Fix mypy error
tomasr8 Oct 14, 2024
870341d
Treat INSTRUCTION_SIZE as an identifier
tomasr8 Oct 14, 2024
421ebda
Regenerate executor cases
tomasr8 Oct 14, 2024
5154f7f
Re-add newline
tomasr8 Oct 14, 2024
e7e83dc
Use replaceText()
tomasr8 Oct 14, 2024
101a5fd
Emit size directly
tomasr8 Oct 15, 2024
1338628
Merge branch 'main' into instr-size
tomasr8 Oct 15, 2024
ee461d5
Pass instruction in tier2
tomasr8 Oct 16, 2024
7135103
Fix INSTRUCTION_SIZE in tier2
tomasr8 Oct 16, 2024
715ce31
Make mypy happy
tomasr8 Oct 16, 2024
8235321
Fix tests
tomasr8 Oct 16, 2024
148070e
Remove unused imports
tomasr8 Oct 17, 2024
3e6b592
Ensure all instructions have the same size
tomasr8 Oct 17, 2024
6e78ec0
Add tests
tomasr8 Oct 17, 2024
75e6f6c
Regen files
tomasr8 Oct 17, 2024
a3c0d10
Make mypy happy
tomasr8 Oct 17, 2024
7235d2d
Fix tests
tomasr8 Oct 20, 2024
5cfb423
Raise instead of assert when size is None
tomasr8 Oct 21, 2024
2190784
Add an `instruction_size` field to the Uop class
tomasr8 Oct 21, 2024
33343dd
Remove extra white space
tomasr8 Oct 21, 2024
f9ecb16
Raise analysis_error instead of ValueError
tomasr8 Oct 21, 2024
abfaaff
Fix wording
tomasr8 Oct 21, 2024
3f3ad10
Make mypy happy
tomasr8 Oct 21, 2024
a8f72ef
Simplify test
tomasr8 Oct 28, 2024
8138a06
Replace assert with raise
tomasr8 Oct 28, 2024
772f803
Simplify code
tomasr8 Oct 28, 2024
a718cfb
Remove some code repetition
tomasr8 Oct 28, 2024
a10d4ee
Simplify INSTRUCTION_SIZE check
tomasr8 Oct 29, 2024
3ae7a5d
Simplify code
tomasr8 Oct 29, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Fix INSTRUCTION_SIZE in tier2
  • Loading branch information
@tomasr8
tomasr8 committed Oct 16, 2024
commit 7135103360147b08de5b609b064f156f282033ee
10 changes: 5 additions & 5 deletions Python/executor_cases.c.h
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

4 changes: 2 additions & 2 deletions Tools/cases_generator/generators_common.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -367,8 +367,8 @@ def instruction_size(self,
inst: Instruction | None
) -> bool:
"""Replace the INSTRUCTION_SIZE macro with the size of the current instruction."""
size = inst.size if inst else 1 + uop.size
self.out.emit(f" {size} ")
assert inst is not None, "INSTRUCTION_SIZE macro requires instruction"
self.out.emit(f" {inst.size} ")
return True

def _print_storage(self, storage: Storage) -> None:
Expand Down