Skip to content

gh-119180: Set the name of the param to __annotate__ to "format" #124730

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
JelleZijlstra merged 7 commits into from
Dec 30, 2024
Merged

gh-119180: Set the name of the param to __annotate__ to "format" #124730

Changes from 1 commit
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
02770d7
gh-119180: Set the name of the param to __annotate__ to "format"
JelleZijlstra Sep 28, 2024
68324ef
fix pydoc
JelleZijlstra Sep 28, 2024
2dae0d0
Add tests
JelleZijlstra Sep 29, 2024
c51b8d0
Merge remote-tracking branch 'upstream/main' into coformatname
JelleZijlstra Sep 30, 2024
90a35be
more tests
JelleZijlstra Sep 30, 2024
b6cbb87
reword comment
JelleZijlstra Oct 1, 2024
c30a54d
Merge branch 'main' into coformatname
JelleZijlstra Dec 30, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
more tests
  • Loading branch information
@JelleZijlstra
JelleZijlstra committed Sep 30, 2024
commit 90a35be6b77150ae11e244fe4623068915799c31
24 changes: 24 additions & 0 deletions Lib/test/test_type_annotations.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -433,3 +433,27 @@ def inner(x: format): pass
"""
ns = run_code(code)
self.assertEqual(ns["res"].__annotations__, {"x": "closure var"})

code = """
def f(x: format):
pass
"""
ns = run_code(code)
# picks up the format() builtin
self.assertEqual(ns["f"].__annotations__, {"x": format})

code = """
def outer():
def f(x: format):
pass
if False:
class format: pass
return f
f = outer()
"""
ns = run_code(code)
with self.assertRaisesRegex(
NameError,
"cannot access free variable 'format' where it is not associated with a value in enclosing scope",
):
ns["f"].__annotations__