Skip to content

gh-124665: add _PyCodec_UnregisterError and _codecs._unregister_error #124677

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
vstinner merged 29 commits into from
Sep 29, 2024
Merged

gh-124665: add _PyCodec_UnregisterError and _codecs._unregister_error #124677

Changes from 1 commit
Commits
Show all changes
29 commits
Select commit Hold shift + click to select a range
24df416
Specify constants for native error policies.
picnixz Sep 27, 2024
a65c1b7
Add `PyCodec_UnregisterError` C API function
picnixz Sep 27, 2024
c1ff9e6
Expose `PyCodec_UnregisterError` as `codecs.unregister_error`
picnixz Sep 27, 2024
5837019
Update stable ABI files.
picnixz Sep 27, 2024
80d1ceb
update ignored.tsv
picnixz Sep 27, 2024
a134f23
add tests
picnixz Sep 27, 2024
47971e9
add docs
picnixz Sep 27, 2024
c00ad8d
add What's New entry
picnixz Sep 27, 2024
cf3bc2f
blurb
picnixz Sep 27, 2024
2108308
docs fix
picnixz Sep 27, 2024
1036516
simplify logic
picnixz Sep 27, 2024
ae601fe
nit: error message standardization
picnixz Sep 27, 2024
864c1ab
Make it a private utility for now.
picnixz Sep 28, 2024
3d9ff15
Revert "docs fix"
picnixz Sep 28, 2024
dbf0d5b
Revert "blurb"
picnixz Sep 28, 2024
5ba676c
Revert "add What's New entry"
picnixz Sep 28, 2024
8a0a0a9
Revert "add docs"
picnixz Sep 28, 2024
7915fa1
Revert "Update stable ABI files."
picnixz Sep 28, 2024
8eaa147
simplify array logic
picnixz Sep 28, 2024
7f41aec
update tests
picnixz Sep 28, 2024
988b34d
fix tests
picnixz Sep 28, 2024
c6e1d98
Duplicate standard error policies to avoid indirection.
picnixz Sep 28, 2024
dd6d210
standardize names
picnixz Sep 28, 2024
b68e54e
PEP 7
picnixz Sep 28, 2024
2c528fe
standardize names
picnixz Sep 28, 2024
c95cd65
revert renaming as well
picnixz Sep 28, 2024
101eb76
use 'built-in' instead of 'standard' terminology
picnixz Sep 28, 2024
903238a
use 'random.getrandbits' instead of 'os.urandom' to generate random IDs
picnixz Sep 28, 2024
a6c692d
address Victor's review
picnixz Sep 28, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
PEP 7
  • Loading branch information
@picnixz
picnixz committed Sep 28, 2024
commit b68e54eba55fddd54cafc03db80681e50f006cf2
3 changes: 2 additions & 1 deletion Python/codecs.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1510,7 +1510,8 @@ _PyCodec_InitRegistry(PyInterpreterState *interp)
return PyStatus_NoMemory();
}

int res = PyDict_SetItemString(interp->codecs.error_registry, error_handlers[i].name, func);
int res = PyDict_SetItemString(interp->codecs.error_registry,
error_handlers[i].name, func);
Py_DECREF(func);
if (res < 0) {
return PyStatus_Error("Failed to insert into codec error registry");
Expand Down