Skip to content

gh-90562: Support zero argument super with dataclasses when slots=True #124455

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ericvsmith merged 8 commits into from
Sep 25, 2024
Merged

gh-90562: Support zero argument super with dataclasses when slots=True #124455

Changes from 1 commit
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
aae4c72
Fix zero-argument super() for dataclasses with slots=True.
ericvsmith Sep 24, 2024
97d4f31
Use assertIs instead of assertEqual for class comparisons. Add a tes…
ericvsmith Sep 24, 2024
c066fe2
Fix default role.
ericvsmith Sep 24, 2024
fbffc50
Improved NEWS entry. Tweak some comments.
ericvsmith Sep 24, 2024
5e1cc0e
Merge branch 'main' into issue-90562-dataclasses-zero-argument-super
ericvsmith Sep 24, 2024
356beed
Fix trivial typo in NEWS.
ericvsmith Sep 24, 2024
c801c6d
Apply suggestions from code review
ericvsmith Sep 24, 2024
1c60e6b
Address review comments: Only update one cell, then break out of the …
ericvsmith Sep 24, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Fix default role.
  • Loading branch information
@ericvsmith
ericvsmith committed Sep 24, 2024
commit c066fe2d98f92bc5ef50376b87e4728282249e9a
2 changes: 1 addition & 1 deletion Misc/NEWS.d/next/Library/2024-09-23-18-26-17.gh-issue-90562.Yj566G.rst
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,2 +1,2 @@
Modify dataclasses to support zero-argument super() when `slots=True` is
Modify dataclasses to support zero-argument super() when ``slots=True`` is
specified.