Skip to content

gh-119180: Fix annotationlib.ForwardRef.evaluate with no globals #124326

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
JelleZijlstra merged 3 commits into from
Sep 23, 2024
Merged

gh-119180: Fix annotationlib.ForwardRef.evaluate with no globals #124326

Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
293fb0a
gh-119180: Fix bug where fwdrefs were evaluated in the annotationlib …
JelleZijlstra Sep 22, 2024
4f08276
More tests
JelleZijlstra Sep 22, 2024
fca05d5
Update Lib/annotationlib.py
JelleZijlstra Sep 23, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
More tests
  • Loading branch information
@JelleZijlstra
JelleZijlstra committed Sep 22, 2024
commit 4f08276e95337d4d4505ae50ff94b53f25dab060
12 changes: 12 additions & 0 deletions Lib/test/test_annotationlib.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -286,6 +286,18 @@ def test_fwdref_with_module(self):
# If globals are passed explicitly, we don't look at the module dict
ForwardRef("Format", module="annotationlib").evaluate(globals={})

def test_fwdref_to_builtin(self):
self.assertIs(ForwardRef("int").evaluate(), int)
self.assertIs(ForwardRef("int", module="collections").evaluate(), int)
self.assertIs(ForwardRef("int", owner=str).evaluate(), int)

# builtins are still searched with explicit globals
self.assertIs(ForwardRef("int").evaluate(globals={}), int)

# explicit values in globals have precedence
obj = object()
self.assertIs(ForwardRef("int").evaluate(globals={"int": obj}), obj)

def test_fwdref_value_is_cached(self):
fr = ForwardRef("hello")
with self.assertRaises(NameError):
Expand Down