Skip to content

gh-101410: support custom messages for domain errors in the math module #124299

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
vstinner merged 13 commits into from
Jan 23, 2025
Merged

gh-101410: support custom messages for domain errors in the math module #124299

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
13 commits
Select commit Hold shift + click to select a range
fb01518
gh-101410: support custom messages for domain errors in the math module
CharlieZhao95 Feb 1, 2023
05b55eb
+1
skirpichev Sep 21, 2024
a917cef
address review:
skirpichev Sep 22, 2024
e8f49b0
address review: tests (few more, reformatting, etc)
skirpichev Sep 22, 2024
0bdbc72
address review: fix typo + cleanup
skirpichev Sep 23, 2024
e9bf987
address review: assertRaises -> assertRaisesRegex
skirpichev Sep 30, 2024
5b2040c
Merge branch 'master' into custom-dom-err-101410
skirpichev Oct 5, 2024
55396f9
Added support for error messages in math_1a(); gamma() as an example
skirpichev Oct 5, 2024
4905f1b
Apply suggestions from code review
skirpichev Oct 5, 2024
96e70f4
Update Modules/mathmodule.c
skirpichev Oct 5, 2024
34b3cad
Merge branch 'master' into custom-dom-err-101410
skirpichev Jan 23, 2025
169815d
address review: tabs in math_1
skirpichev Jan 23, 2025
8d28fd8
address review: improve message in loghelper()
skirpichev Jan 23, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
address review: improve message in loghelper()
  • Loading branch information
@skirpichev
skirpichev committed Jan 23, 2025
commit 8d28fd8cba178d35efcea743d05e4e2d90f523ea
2 changes: 1 addition & 1 deletion Lib/test/test_math.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2533,7 +2533,7 @@ def test_exception_messages(self):
math.log(x)
x = -123
with self.assertRaisesRegex(ValueError,
f"expected a positive input"):
f"expected a positive input, got {x}"):
math.log(x)
with self.assertRaisesRegex(ValueError,
f"expected a float or nonnegative integer, got {x}"):
Expand Down
4 changes: 2 additions & 2 deletions Modules/mathmodule.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2232,8 +2232,8 @@ loghelper(PyObject* arg, double (*func)(double))

/* Negative or zero inputs give a ValueError. */
if (!_PyLong_IsPositive((PyLongObject *)arg)) {
PyErr_SetString(PyExc_ValueError,
"expected a positive input");
PyErr_Format(PyExc_ValueError,
"expected a positive input, got %S", arg);
return NULL;
}

Expand Down