Skip to content

gh-124096: Enable REPL virtual terminal support on Windows #124119

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ambv merged 13 commits into from
Feb 23, 2025
Merged

gh-124096: Enable REPL virtual terminal support on Windows #124119

Changes from 1 commit
Commits
Show all changes
13 commits
Select commit Hold shift + click to select a range
3db0eb7
NEWS for Windows REPL virtual terminal support
y5c4l3 Sep 16, 2024
6d96558
Add Windows REPL virtual terminal queue
y5c4l3 Sep 16, 2024
0fed3f7
Enable virtual terminal mode in Windows REPL
y5c4l3 Sep 16, 2024
f897500
Merge in the main branch
encukou Jan 23, 2025
d3a1698
In VM mode, always request bracketed paste
encukou Jan 23, 2025
89ba4f2
event_queue is no longer a deque
encukou Jan 23, 2025
290aa5e
Update Lib/_pyrepl/windows_eventqueue.py
pablogsal Jan 23, 2025
2b90017
Apply suggestions from code review
encukou Feb 5, 2025
74f8560
Merge branch 'main' into windows-vt
encukou Feb 5, 2025
cfc66eb
Deduplicate common EventQueue code; run the tests on both OSes
encukou Feb 14, 2025
0ccf330
Merge in the main branch
encukou Feb 14, 2025
2867297
Adjust the test
encukou Feb 14, 2025
b15261b
Annotation, not default...
encukou Feb 14, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Adjust the test 
The patch decorator was being called even on the skipped test.
  • Loading branch information
@encukou
encukou committed Feb 14, 2025
commit 2867297628b6b9d4ce988218d032a9404703abc6
8 changes: 4 additions & 4 deletions Lib/test/test_pyrepl/test_eventqueue.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,7 @@
import unittest
import sys
from unittest.mock import patch
from test import support

try:
from _pyrepl.console import Event
Expand Down Expand Up @@ -123,10 +124,10 @@ def test_push_unrecognized_escape_sequence(self):
self.assertEqual(eq.events[2].data, "Z")


@unittest.skipIf(sys.platform == "win32", "No Unix event queue on Windows")
@patch("_pyrepl.curses.tigetstr", lambda x: b"")
@unittest.skipIf(support.MS_WINDOWS, "No Unix event queue on Windows")
class TestUnixEventQueue(EventQueueTestBase, unittest.TestCase):
def setUp(self):
self.enterContext(patch("_pyrepl.curses.tigetstr", lambda x: b""))
self.file = tempfile.TemporaryFile()

def tearDown(self) -> None:
Expand All @@ -136,8 +137,7 @@ def make_eventqueue(self) -> base_eventqueue.BaseEventQueue:
return unix_eventqueue.EventQueue(self.file.fileno(), "utf-8")


@unittest.skipIf(sys.platform != "win32", "No Windows event queue on Unix")
@patch("_pyrepl.curses.tigetstr", lambda x: b"")
@unittest.skipUnless(support.MS_WINDOWS, "No Windows event queue on Unix")
class TestWindowsEventQueue(EventQueueTestBase, unittest.TestCase):
def make_eventqueue(self) -> base_eventqueue.BaseEventQueue:
return windows_eventqueue.EventQueue("utf-8")