Skip to content

gh-123969: refactor _PyErr_RaiseSyntaxError and _PyErr_EmitSyntaxWarning out of compiler #123972

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
iritkatriel merged 8 commits into from
Sep 16, 2024
Merged

gh-123969: refactor _PyErr_RaiseSyntaxError and _PyErr_EmitSyntaxWarning out of compiler #123972

Changes from 1 commit
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
b3deb0f
gh-123969: refactor _PyErr_RaiseSyntaxError and _PyErr_EmitSyntaxWarn…
iritkatriel Sep 11, 2024
6c0d57b
whitespace
iritkatriel Sep 11, 2024
8523c1b
review comments
iritkatriel Sep 13, 2024
4a007f4
Py_NewRef
iritkatriel Sep 13, 2024
763b250
increment cols in caller
iritkatriel Sep 16, 2024
167a67c
Merge branch 'main' into syntax-error
iritkatriel Sep 16, 2024
d568737
increment cols in caller
iritkatriel Sep 16, 2024
c679776
increment cols in caller - one more place
iritkatriel Sep 16, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
increment cols in caller - one more place
  • Loading branch information
@iritkatriel
iritkatriel committed Sep 16, 2024
commit c679776f462ba0ccf45064345559333056713cb0
4 changes: 2 additions & 2 deletions Python/compile.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1132,8 +1132,8 @@ _PyCompile_Warn(compiler *c, location loc, const char *format, ...)
if (msg == NULL) {
return ERROR;
}
int ret = _PyErr_EmitSyntaxWarning(msg, c->c_filename, loc.lineno, loc.col_offset,
loc.end_lineno, loc.end_col_offset);
int ret = _PyErr_EmitSyntaxWarning(msg, c->c_filename, loc.lineno, loc.col_offset + 1,
loc.end_lineno, loc.end_col_offset + 1);
Py_DECREF(msg);
return ret;
}
Expand Down