Skip to content

gh-120221: Support KeyboardInterrupt in asyncio REPL #123795

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ambv merged 4 commits into from
Sep 6, 2024
Merged

gh-120221: Support KeyboardInterrupt in asyncio REPL #123795

Changes from 1 commit
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
49a0753
gh-120221: Support KeyboardInterrupt in asyncio REPL
ambv Sep 6, 2024
7e95b70
Don't stop consuming the buffer you already have, my goodness
ambv Sep 6, 2024
fa51a95
Add Blurb
ambv Sep 6, 2024
e28481a
Fix timeout on Windows being in seconds instead of millis
ambv Sep 6, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Add Blurb
  • Loading branch information
@ambv
ambv committed Sep 6, 2024
commit fa51a95979ff86e80c06c656ab5c89869abe04ee
2 changes: 2 additions & 0 deletions Misc/NEWS.d/next/Core_and_Builtins/2024-09-06-19-23-44.gh-issue-120221.giJEDT.rst
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,2 @@
asyncio REPL is now again properly recognizing KeyboardInterrupts. Display

@Eclips4 Eclips4 Sep 6, 2024

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
asyncio REPL is now again properly recognizing KeyboardInterrupts. Display
asyncio REPL is now again properly recognizing :exc:`KeyboardInterrupt`. Display

@ambv ambv Sep 6, 2024

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That's not the same word. Let's do stuff like that in a subsequent PR please, so we don't waste time on CI now.

@Eclips4 Eclips4 Sep 6, 2024

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Agreed. The upcoming release is more important now.

@picnixz picnixz Sep 6, 2024

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

FTR, to put the s, you would do :exc:`KeyboardInterrupt`\s

of exceptions raised in secondary threads is fixed.