Skip to content

gh-123497: New limit for Python integers on 64-bit platforms #123498

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
serhiy-storchaka wants to merge 7 commits into from
Closed

gh-123497: New limit for Python integers on 64-bit platforms #123498

Changes from 1 commit
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
c2af856
gh-123497: New limit for Python integers on 64-bit platforms
serhiy-storchaka Aug 30, 2024
7c3d3fc
Merge branch 'main' into integer-upper-limit
serhiy-storchaka Sep 3, 2024
4eaa5fd
Address review comments.
serhiy-storchaka Sep 4, 2024
7ec9116
Merge branch 'main' into integer-upper-limit
serhiy-storchaka Sep 4, 2024
ee87e7f
Update Objects/longobject.c
serhiy-storchaka Sep 4, 2024
ef9277a
Fix MAX_LONG_DIGITS on 32-bit platforms.
serhiy-storchaka Sep 5, 2024
b2be034
Merge branch 'main' into integer-upper-limit
serhiy-storchaka Sep 27, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Address review comments.
  • Loading branch information
@serhiy-storchaka
serhiy-storchaka committed Sep 4, 2024
commit 4eaa5fdace45d302e9e8e0cd45f4cf68cc81ebe2
6 changes: 4 additions & 2 deletions Objects/longobject.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1247,7 +1247,7 @@ PyLong_AsNativeBytes(PyObject* vv, void* buffer, Py_ssize_t n, int flags)
/* Calculates the number of bits required for the *absolute* value
* of v. This does not take sign into account, only magnitude. */
uint64_t nb = _PyLong_NumBits((PyObject *)v);
/* Normally this would be((nb - 1) / 8) + 1 to avoid rounding up
/* Normally this would be ((nb - 1) / 8) + 1 to avoid rounding up
* multiples of 8 to the next byte, but we add an implied bit for
* the sign and it cancels out. */
res = (Py_ssize_t)(nb / 8) + 1;
Expand Down Expand Up @@ -6175,7 +6175,9 @@ static PyObject *
int_bit_length_impl(PyObject *self)
/*[clinic end generated code: output=fc1977c9353d6a59 input=e4eb7a587e849a32]*/
{
return PyLong_FromUInt64(_PyLong_NumBits(self));
uint64_t nbits =_PyLong_NumBits(self);
Comment thread
serhiy-storchaka marked this conversation as resolved.
Outdated
assert(!PyErr_Occurred());
return PyLong_FromUInt64(nbits);
}

static int
Expand Down