Skip to content

gh-123448: Move _PyNoDefault_Type to the static types array #123449

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
JelleZijlstra merged 2 commits into from
Aug 29, 2024
Merged

gh-123448: Move _PyNoDefault_Type to the static types array #123449

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
0f6158e
Move NoDefaultType to the static types array.
ZeroIntensity Aug 29, 2024
42dc304
Add NEWS entry.
ZeroIntensity Aug 29, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Next Next commit
Move NoDefaultType to the static types array.
  • Loading branch information
@ZeroIntensity
ZeroIntensity committed Aug 29, 2024
commit 0f6158e5d025ba46b95c85c6ba0fc24039c3a5f4
3 changes: 0 additions & 3 deletions Modules/_typingmodule.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -63,9 +63,6 @@ _typing_exec(PyObject *m)
if (PyModule_AddObjectRef(m, "TypeAliasType", (PyObject *)&_PyTypeAlias_Type) < 0) {
return -1;
}
if (PyType_Ready(&_PyNoDefault_Type) < 0) {
return -1;
}
if (PyModule_AddObjectRef(m, "NoDefault", (PyObject *)&_Py_NoDefaultStruct) < 0) {
return -1;
}
Expand Down
1 change: 1 addition & 0 deletions Objects/object.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2347,6 +2347,7 @@ static PyTypeObject* static_types[] = {
&_PyWeakref_ProxyType,
&_PyWeakref_RefType,
&_PyTypeAlias_Type,
&_PyNoDefault_Type,

// subclasses: _PyTypes_FiniTypes() deallocates them before their base
// class
Expand Down