Skip to content

GH-73991: Disallow copying directory into itself via pathlib.Path.copy() #122924

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
barneygale merged 9 commits into from
Aug 23, 2024
Merged

GH-73991: Disallow copying directory into itself via pathlib.Path.copy() #122924

Changes from 1 commit
Commits
Show all changes
9 commits
Select commit Hold shift + click to select a range
e2b4c6d
GH-73991: Disallow copying directory into itself via `pathlib.Path.co…
barneygale Aug 12, 2024
d646ad2
Tweak import
barneygale Aug 12, 2024
c5a79d0
Expand tests
barneygale Aug 12, 2024
f58c07a
Add comment to _ensure_distinct_path()
barneygale Aug 13, 2024
b119e3d
Improve wording
barneygale Aug 13, 2024
32530b7
Add tests for symlink-to-other-symlink copies.
barneygale Aug 18, 2024
a15f248
Fix windows tests
barneygale Aug 18, 2024
d371b89
More Windows goodness
barneygale Aug 18, 2024
7f5b1ab
Address review feedback
barneygale Aug 23, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Expand tests
  • Loading branch information
@barneygale
barneygale committed Aug 12, 2024
commit c5a79d043e7a69ec23a637c66e70ece8ccc091f6
21 changes: 21 additions & 0 deletions Lib/test/test_pathlib/test_pathlib_abc.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1758,6 +1758,12 @@ def test_copy_symlink_follow_symlinks_false(self):
self.assertTrue(target.is_symlink())
self.assertEqual(source.readlink(), target.readlink())

@needs_symlinks
def test_copy_symlink_to_itself(self):
base = self.cls(self.base)
source = base / 'linkA'
self.assertRaises(OSError, source.copy, source)

@needs_symlinks
def test_copy_directory_symlink_follow_symlinks_false(self):
base = self.cls(self.base)
Expand All @@ -1769,6 +1775,20 @@ def test_copy_directory_symlink_follow_symlinks_false(self):
self.assertTrue(target.is_symlink())
self.assertEqual(source.readlink(), target.readlink())

@needs_symlinks
def test_copy_directory_symlink_to_itself(self):
base = self.cls(self.base)
source = base / 'linkB'
self.assertRaises(OSError, source.copy, source)
Comment thread
barneygale marked this conversation as resolved.

@needs_symlinks
def test_copy_directory_symlink_into_itself(self):
base = self.cls(self.base)
source = base / 'linkB'
/ 'linkB' / 'copyB'
self.assertRaises(OSError, source.copy, target)
Comment thread
barneygale marked this conversation as resolved.
self.assertFalse(target.exists())

def test_copy_file_to_existing_file(self):
base = self.cls(self.base)
source = base / 'fileA'
Expand Down Expand Up @@ -1933,6 +1953,7 @@ def test_copy_dir_into_itself(self):
source = base / 'dirC'
/ 'dirC' / 'dirD' / 'copyC'
self.assertRaises(OSError, source.copy, target)
Comment thread
barneygale marked this conversation as resolved.
self.assertFalse(target.exists())

def test_copy_missing_on_error(self):
base = self.cls(self.base)
Expand Down