Skip to content

gh-122858: Deprecate asyncio.iscoroutinefunction #122875

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
kumaraditya303 merged 16 commits into from
Aug 11, 2024
Merged

gh-122858: Deprecate asyncio.iscoroutinefunction #122875

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
16 commits
Select commit Hold shift + click to select a range
1036f01
Deprecate :func:`asyncio.iscoroutinefunction` in favor of :func:`insp…
Wulian233 Aug 10, 2024
228d2f2
gh:`122875`
Wulian233 Aug 10, 2024
c831bb1
typo
Wulian233 Aug 10, 2024
d48ed66
fix
Wulian233 Aug 10, 2024
7aae62f
fix
Wulian233 Aug 10, 2024
ae0b8f0
fix
Wulian233 Aug 10, 2024
62b8d3b
Apply suggestions from code review
kumaraditya303 Aug 10, 2024
750d294
use coroutines.iscoroutine and coroutines._iscoroutinefunction
Wulian233 Aug 10, 2024
78655aa
import coroutines
Wulian233 Aug 10, 2024
58013d5
Update Misc/NEWS.d/next/Library/2024-08-10-10-21-44.gh-issue-122858.Z…
kumaraditya303 Aug 10, 2024
1be0d66
from inspect import iscoroutinefunction
Wulian233 Aug 10, 2024
840191d
remove
Wulian233 Aug 10, 2024
e0f0272
test_pep492.py
Wulian233 Aug 10, 2024
231cfb3
finish
Wulian233 Aug 10, 2024
c1f2743
test_pep492
Wulian233 Aug 11, 2024
d8c86c6
fix tests
kumaraditya303 Aug 11, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
fix
  • Loading branch information
@Wulian233
Wulian233 committed Aug 10, 2024
commit d48ed666cacfc30216fbef2e4a5a308f8d34a318
2 changes: 1 addition & 1 deletion Doc/whatsnew/3.14.rst
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -425,7 +425,7 @@ Deprecated
:c:macro:`!isfinite` available from :file:`math.h`
since C99. (Contributed by Sergey B Kirpichev in :gh:`119613`.)

* :mod:`asyncio`: :func:`asyncio.iscoroutinefunction` is deprecated
* :mod:`asyncio`: :func:`asyncio.coroutines.iscoroutinefunction` is deprecated
and will be removed in Python 3.16;
Comment thread
kumaraditya303 marked this conversation as resolved.
Outdated
use :func:`inspect.iscoroutinefunction` instead.
(Contributed by Jiahao Li in :gh:`122875`.)
Expand Down
2 changes: 1 addition & 1 deletion Lib/asyncio/coroutines.py
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
__all__ = ['iscoroutinefunction', 'iscoroutine']
__all__ = 'iscoroutinefunction', 'iscoroutine'

import collections.abc
import inspect
Expand Down
2 changes: 1 addition & 1 deletion Misc/NEWS.d/next/Library/2024-08-10-10-21-44.gh-issue-122858.ZC1rJD.rst
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,2 +1,2 @@
Deprecate :func:`asyncio.iscoroutinefunction` in favor of
Deprecate :func:`asyncio.coroutines.iscoroutinefunction` in favor of
Comment thread
kumaraditya303 marked this conversation as resolved.
Outdated
:func:`inspect.iscoroutinefunction`.