Skip to content

gh-118943: Remove 'regen-jit' from the 'regen-all' make target #122602

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
brandtbucher merged 6 commits into from
Aug 8, 2024
Merged

gh-118943: Remove 'regen-jit' from the 'regen-all' make target #122602

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
a593b7c
gh-118943: Remove 'regen-jit' from the 'regen-all' make target
hroncok Aug 2, 2024
73cfd83
fixup Consistency
hroncok Aug 3, 2024
9b18b68
fixup Call make regen-jit from the JIT workflow
hroncok Aug 3, 2024
e21a156
Check for changes in regen-jit
hroncok Aug 3, 2024
c41b712
Revert the CI changes and user-facing echo
hroncok Aug 5, 2024
3b49147
Update Misc/NEWS.d/next/Build/2024-08-02-12-59-15.gh-issue-118943.vZQ…
hroncok Aug 5, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .github/workflows/build.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -85,7 +85,7 @@ jobs:
- name: Build CPython
run: |
make -j4 regen-all
make regen-stdlib-module-names regen-sbom
make regen-stdlib-module-names regen-sbom regen-jit
Comment thread
hroncok marked this conversation as resolved.
Outdated
- name: Check for changes
run: |
git add -u
Expand Down
4 changes: 2 additions & 2 deletions Makefile.pre.in
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1665,10 +1665,10 @@ regen-unicodedata:
regen-all: regen-cases regen-typeslots \
regen-token regen-ast regen-keyword regen-sre regen-frozen \
regen-pegen-metaparser regen-pegen regen-test-frozenmain \
regen-test-levenshtein regen-global-objects regen-jit
regen-test-levenshtein regen-global-objects
@echo
@echo "Note: make regen-stdlib-module-names, make regen-limited-abi, "
@echo "make regen-configure, make regen-sbom, and make regen-unicodedata should be run manually"
@echo "make regen-configure, make regen-sbom, regen-jit, and make regen-unicodedata should be run manually"
Comment thread
hroncok marked this conversation as resolved.
Outdated

############################################################################
# Special rules for object files
Expand Down
2 changes: 2 additions & 0 deletions Misc/NEWS.d/next/Build/2024-08-02-12-59-15.gh-issue-118943.vZQtET.rst
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,2 @@
The ``regen-jit`` make target is no longer part of ``regen-all`` to avoid various
race conditions when running ``regen-all``.
Comment thread
hroncok marked this conversation as resolved.
Outdated