Skip to content

GH-73991: Rework pathlib.Path.copytree() into copy() #122369

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
barneygale merged 20 commits into from
Aug 11, 2024
Merged

GH-73991: Rework pathlib.Path.copytree() into copy() #122369

Changes from 1 commit
Commits
Show all changes
20 commits
Select commit Hold shift + click to select a range
b7ce838
GH-73991: Rework `pathlib.Path.copytree()` into `copy()`.
barneygale Jul 27, 2024
76cf893
Simplify handling of symlinks
barneygale Jul 27, 2024
b10a3b5
Inline _copy_metadata()
barneygale Jul 28, 2024
a67f5a7
Further symlink tweaks
barneygale Jul 28, 2024
017dd86
Fix copying metadata to non-symlinks
barneygale Jul 28, 2024
fcc8af1
Specify target_is_directory when symlinking.
barneygale Jul 28, 2024
57efe1f
Tiny simplification.
barneygale Jul 28, 2024
8bef16b
Skip unnecessary is_dir() when copying symlinks on POSIX.
barneygale Jul 29, 2024
a51ce63
Docs tweaks
barneygale Jul 30, 2024
51b1e6d
Fix CopyFile2 check
barneygale Aug 4, 2024
429c7b6
Merge branch 'main' into merge-copy-copytree
barneygale Aug 4, 2024
023b3a4
Docs tweak
barneygale Aug 4, 2024
4d6d2dc
Address review feedback
barneygale Aug 4, 2024
7801edf
Merge branch 'main' into merge-copy-copytree
barneygale Aug 6, 2024
5ce229b
Merge branch 'main' into merge-copy-copytree
barneygale Aug 7, 2024
5a94525
Return the target as a Path object.
barneygale Aug 7, 2024
3b6405b
Apply suggestions from code review
barneygale Aug 7, 2024
03f9b7f
Address some review feedback
barneygale Aug 7, 2024
02e9237
Simplify tracebacks
barneygale Aug 7, 2024
fed93fc
Use absolute imports
barneygale Aug 10, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Further symlink tweaks
  • Loading branch information
@barneygale
barneygale committed Jul 28, 2024
commit a67f5a7d93151d66ca37bdc2a9caf8861bad91b7
6 changes: 3 additions & 3 deletions Lib/pathlib/_abc.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -837,14 +837,14 @@ def on_error(err):
while stack:
source,>
try:
if source.is_dir(follow_symlinks=follow_symlinks):
if not follow_symlinks and source.is_symlink():
target.symlink_to(source.readlink())
elif source.is_dir():
children = source.iterdir()
target.mkdir(exist_ok=dirs_exist_ok)
for child in children:
if not (ignore and ignore(child)):
stack.append((child, target.joinpath(child.name)))
elif not follow_symlinks and source.is_symlink():
target.symlink_to(source.readlink())
else:
source._copy_data(target)
if preserve_metadata:
Expand Down