Skip to content

gh-122320: Add _testinternalcapi.is_dict_version_overflowed #122324

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
Eclips4 wants to merge 10 commits into from
Closed

gh-122320: Add _testinternalcapi.is_dict_version_overflowed #122324

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
10 commits
Select commit Hold shift + click to select a range
90493a7
Add ``_PyDictKeys_SetVersionForCurrentState``
Eclips4 Jul 26, 2024
d6ea5b3
Reword comment
Eclips4 Jul 26, 2024
9efae8b
Avoid creating new C API
Eclips4 Jul 27, 2024
c74602b
Remove ``reset_version``; Add ``is_version_overflowed``
Eclips4 Aug 2, 2024
8e4402b
Update header
Eclips4 Aug 2, 2024
96d3f29
Resolve merge conflict
Eclips4 Aug 21, 2024
3458a9d
Rename is_version_overflowed to is_dict_version_overflowed
Eclips4 Sep 16, 2024
c20c278
temp remmoval
Eclips4 Dec 28, 2024
ad18436
Merge branch 'main' into issue-122320
Eclips4 Dec 28, 2024
b6b24a4
Resolve merge conflict
Eclips4 Dec 28, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
temp remmoval
  • Loading branch information
@Eclips4
Eclips4 committed Dec 28, 2024
commit c20c278163eb4b24f7d6ab93cc57e2016bfc7b6e
20 changes: 0 additions & 20 deletions Modules/_testinternalcapi.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2034,25 +2034,6 @@ gh_119213_getargs_impl(PyObject *module, PyObject *spam)
return Py_NewRef(spam);
}

/*[clinic input]
is_dict_version_overflowed

dict: object(type="PyDictObject *", subclass_of="&PyDict_Type")

[clinic start generated code]*/

static PyObject *
is_dict_version_overflowed_impl(PyObject *module, PyDictObject *dict)
/*[clinic end generated code: output=85daaa03aef739fd input=a0a9e8265cd6ae23]*/
{
PyInterpreterState *interp = _PyInterpreterState_GET();
uint32_t keys_version = _PyDictKeys_GetVersionForCurrentState(interp, dict->ma_keys);
if (keys_version != (uint16_t)keys_version){
Py_RETURN_TRUE;
}
Py_RETURN_FALSE;
}

static PyObject *
get_static_builtin_types(PyObject *self, PyObject *Py_UNUSED(ignored))
{
Expand Down Expand Up @@ -2163,7 +2144,6 @@ static PyMethodDef module_functions[] = {
GH_119213_GETARGS_METHODDEF
{"get_static_builtin_types", get_static_builtin_types, METH_NOARGS},
{"identify_type_slot_wrappers", identify_type_slot_wrappers, METH_NOARGS},
IS_DICT_VERSION_OVERFLOWED_METHODDEF
{NULL, NULL} /* sentinel */
};

Expand Down
60 changes: 1 addition & 59 deletions Modules/clinic/_testinternalcapi.c.h
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.