Skip to content

gh-117482: Fix the Slot Wrapper Inheritance Tests #122248

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ericsnowcurrently merged 6 commits into from
Jul 29, 2024
Merged

gh-117482: Fix the Slot Wrapper Inheritance Tests #122248

Changes from 1 commit
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
85182ae
Fix test_slot_wrappers and test_static_types_inherited_slots.
ericsnowcurrently Jul 24, 2024
8eb5645
Skip test_static_types_inherited_slots temporarily.
ericsnowcurrently Jul 24, 2024
777511f
Fix the test name.
ericsnowcurrently Jul 26, 2024
560540c
Move the helpers to test.support.
ericsnowcurrently Jul 26, 2024
700fb9e
Avoid excessively long commandline arguments.
ericsnowcurrently Jul 26, 2024
60ad88d
Merge branch 'main' into fix-slot-wrapper-inheritance-tests
ericsnowcurrently Jul 27, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Fix the test name.
  • Loading branch information
@ericsnowcurrently
ericsnowcurrently committed Jul 27, 2024
commit 777511f217ab89a3d9ff13d119085017db6e8866
2 changes: 1 addition & 1 deletion Lib/test/test_types.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2449,7 +2449,7 @@ def setUpClass(cls):
@cpython_only
@no_rerun('channels (and queues) might have a refleak; see gh-122199')
@unittest.skipIf(is_apple_mobile, "Fails on iOS due to test ordering; see #121832.")
def test_slot_wrappers(self):
def test_static_types_inherited_slots(self):
rch, sch = interpreters.channels.create()

slots = []
Expand Down