Skip to content

gh-122191: Fix test_warnings failure if run with -Werror #122222

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
serhiy-storchaka merged 4 commits into from
Jul 25, 2024
Merged

gh-122191: Fix test_warnings failure if run with -Werror #122222

Changes from 1 commit
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
cdbc98d
gh-122191: Fix test_warnings failure if run with -Werror
serhiy-storchaka Jul 24, 2024
2dee352
Apply suggestion from review.
serhiy-storchaka Jul 24, 2024
2be8c31
Apply suggestions from code review
serhiy-storchaka Jul 24, 2024
9764074
Ensure that get_source() was called.
serhiy-storchaka Jul 24, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
35 changes: 18 additions & 17 deletions Lib/test/test_warnings/__init__.py
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,7 @@
from contextlib import contextmanager
import linecache
import os
import importlib
import inspect
from io import StringIO
import re
Expand Down Expand Up @@ -887,37 +888,37 @@ def test_issue31285(self):
# warn_explicit() should neither raise a SystemError nor cause an
# assertion failure, in case the return value of get_source() has a
# bad splitlines() method.
def get_bad_loader(splitlines_ret_val):
class BadLoader:
def get_source(self, fullname):
class BadSource(str):
def splitlines(self):
return splitlines_ret_val
return BadSource('spam')
return BadLoader()

class BadLoader:
def get_source(self, fullname):
class BadSource(str):
def splitlines(self):
return splitlines_ret_val
return BadSource('spam')

loader = BadLoader()
spec = importlib.machinery.ModuleSpec('foobar', loader)
module_globals = {'__loader__': loader,
'__spec__': spec,
'__name__': 'foobar'}
Comment thread
AlexWaygood marked this conversation as resolved.
Outdated
wmod = self.module
with original_warnings.catch_warnings(module=wmod):
wmod.filterwarnings('default', category=UserWarning)

splitlines_ret_val = 42
with support.captured_stderr() as stderr:
wmod.warn_explicit(
'foo', UserWarning, 'bar', 1,
module_globals={'__loader__': get_bad_loader(42),
'__name__': 'foobar'})
module_globals=module_globals)
self.assertIn('UserWarning: foo', stderr.getvalue())

show = wmod._showwarnmsg
try:
with support.swap_attr(wmod, '_showwarnmsg', None):
del wmod._showwarnmsg
splitlines_ret_val = [42]
with support.captured_stderr() as stderr:
wmod.warn_explicit(
'eggs', UserWarning, 'bar', 1,
module_globals={'__loader__': get_bad_loader([42]),
'__name__': 'foobar'})
module_globals=module_globals)
self.assertIn('UserWarning: eggs', stderr.getvalue())
finally:
wmod._showwarnmsg = show

@support.cpython_only
def test_issue31411(self):
Expand Down