Skip to content

bpo-36211: Change the output with the full URL when executing make -C Doc/ serve #12195

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
matrixise wants to merge 4 commits into from
Closed

bpo-36211: Change the output with the full URL when executing make -C Doc/ serve #12195

Changes from 1 commit
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
5ffec2e
bpo-36211: Change the output with the full URL when executing `make -…
matrixise Mar 6, 2019
4c22aca
Use the loopback address 127.0.0.1 and use the values from the socket
matrixise Mar 17, 2019
9bad8f4
bind on 0.0.0.0 and show 127.0.0.1 and improve the print message
matrixise Mar 18, 2019
b4df314
remove empty line
matrixise Mar 18, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
bind on 0.0.0.0 and show 127.0.0.1 and improve the print message
  • Loading branch information
@matrixise
matrixise committed Mar 18, 2019
commit 9bad8f4dcafc743e7173bebd405eddc1113e0e3b
10 changes: 6 additions & 4 deletions Tools/scripts/serve.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -28,10 +28,12 @@ def app(environ, respond):
path = sys.argv[1]
port = int(sys.argv[2]) if len(sys.argv) > 2 else 8000

# by security, the default interface is the loopback address, 127.0.0.1
httpd = simple_server.make_server('127.0.0.1', port, app)
interface, port = httpd.socket.getsockname()
print("Serving {0} on {1} port {2} (http://{1}:{2}/), control-C to stop".format(path, interface, port))
httpd = simple_server.make_server('', port, app)

message = "Serving {0} on {1} port {3} (http://{2}:{3}/), control-C to stop"
parameters = (path, "0.0.0.0", "127.0.0.1", port)

print(message.format(*parameters))
try:
httpd.serve_forever()
except KeyboardInterrupt:
Expand Down